Date: Mon, 30 Mar 2020 09:28:00 +1100 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359419 - head/usr.bin/ncal Message-ID: <20200329222800.GE87815@eureka.lemis.com> In-Reply-To: <202003291103.02TB393j051396@gndrsh.dnsmgr.net> References: <202003290418.02T4IR46003292@repo.freebsd.org> <202003291103.02TB393j051396@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--oOB74oR0WcNeq9Zb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sunday, 29 March 2020 at 4:03:09 -0700, Rodney W. Grimes wrote: >> Author: grog >> Date: Sun Mar 29 04:18:27 2020 >> New Revision: 359419 >> URL: https://svnweb.freebsd.org/changeset/base/359419 >> >> Log: >> Remove spurious transition from Julian to Gregorian for country >> "Latin". >> >> Arguably the entire -p option should be removed. It shows only a few >> countries, and it doesn't have any relationship with the rest of the >> program. > > This commit message and the diff below do not seem to match very well. > Is this actually what you intended to commit? The material difference, yes. Do you have an issue with that? It seems that some trailing blanks in unrelated text were removed as well. diff doesn't show these by default, so they crept through. I know it's bad style to mix style commits with functional commits, but ultimately they had to go too. Greg -- Sent from my desktop computer. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. This message is digitally signed. If your Microsoft mail program reports problems, please read http://lemis.com/broken-MUA --oOB74oR0WcNeq9Zb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAl6BIPAACgkQIubykFB6QiP9QACdGzjB3i4mqbxr9Vy+o01E3DWL 04AAn03kd3D1HAplOUsSuFN49t9mF/5c =HewY -----END PGP SIGNATURE----- --oOB74oR0WcNeq9Zb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200329222800.GE87815>