Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Jun 2013 03:43:36 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@FreeBSD.org
Subject:   ports/179699: [PATCH] sysutils/lxterminal: Add license, NLS option and fix, take maintainership
Message-ID:  <20130619014339.A68C6AFF@hub.freebsd.org>
Resent-Message-ID: <201306190150.r5J1o0f2080452@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179699
>Category:       ports
>Synopsis:       [PATCH] sysutils/lxterminal: Add license, NLS option and fix, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 19 01:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Take maintainership
- Remove leading article from COMMENT
- Add license (GPLv2)
- Add docs
- Add NLS Option
- Fix NLS
- Trim pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130619004500-47427/

>Fix:

--- lxterminal-0.1.11_1.patch begins here ---
diff -ruN /usr/ports/sysutils/lxterminal/Makefile ./Makefile
--- /usr/ports/sysutils/lxterminal/Makefile	2013-06-18 18:26:44.000000000 +0200
+++ ./Makefile	2013-06-19 03:38:40.000000000 +0200
@@ -7,19 +7,26 @@
 CATEGORIES=	sysutils
 MASTER_SITES=	SF/lxde/LXTerminal%20%28terminal%20emulator%29/LXTerminal%20${PORTVERSION}
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A lightweight terminal emulator from the LXDE project
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Lightweight terminal emulator from the LXDE project
+
+LICENSE=	GPLv2
 
 LIB_DEPENDS=	vte.9:${PORTSDIR}/x11-toolkits/vte
 
-USE_GNOME=	gtk20 intlhack
-USE_GMAKE=	yes
 USES=		iconv
+USE_GNOME=	gtk20 intlhack
 GNU_CONFIGURE=	yes
-USE_LDCONFIG=	yes
 CONFIGURE_ARGS=	--prefix=${PREFIX}
+USE_GMAKE=	yes
+USE_LDCONFIG=	yes
+
 MAN1=		lxterminal.1
 
+PORTDOCS=	AUTHORS README
+
+OPTIONS_DEFINE=	NLS
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
@@ -28,8 +35,19 @@
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 .else
-CONFIGURE_ARGS+=--disable-nls
 PLIST_SUB+=	NLS="@comment "
 .endif
 
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|src po|src|' \
+		${WRKSRC}/Makefile.in
+.endif
+
+post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
 .include <bsd.port.mk>
diff -ruN /usr/ports/sysutils/lxterminal/pkg-plist ./pkg-plist
--- /usr/ports/sysutils/lxterminal/pkg-plist	2013-06-02 18:58:48.000000000 +0200
+++ ./pkg-plist	2013-06-19 01:50:31.000000000 +0200
@@ -1,4 +1,5 @@
 bin/lxterminal
+share/applications/lxterminal.desktop
 %%NLS%%share/locale/af/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/ar/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/be/LC_MESSAGES/lxterminal.mo
@@ -56,27 +57,18 @@
 %%NLS%%share/locale/vi/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/zh_CN/LC_MESSAGES/lxterminal.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/lxterminal.mo
-share/applications/lxterminal.desktop
+%%DATADIR%%/lxterminal-preferences.ui
+%%DATADIR%%/lxterminal.conf
 share/pixmaps/lxterminal.png
-share/lxterminal/lxterminal.conf
-share/lxterminal/lxterminal-preferences.ui
-@dirrm share/lxterminal
+@dirrm %%DATADIR%%
 @dirrmtry share/applications
-%%NLS%%@dirrmtry share/locale/nb_NO/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/nb_NO
-%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/es_VE
-%%NLS%%@dirrmtry share/locale/fo/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/fo
-%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/frp
-%%NLS%%@dirrmtry share/locale/lg/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/lg
-%%NLS%%@dirrmtry share/locale/sr@latin/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/sr@latin
-%%NLS%%@dirrmtry share/locale/te/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/te
-%%NLS%%@dirrmtry share/locale/tt_RU/LC_MESSAGES
-%%NLS%%@dirrmtry share/locale/tt_RU
 %%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/tt_RU/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/tt_RU
+%%NLS%%@dirrmtry share/locale/lg/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/lg
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
--- lxterminal-0.1.11_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130619014339.A68C6AFF>