Date: Sun, 7 Jun 2015 10:06:54 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Marcelo Araujo <araujo@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r284116 - head/sys/boot/ficl Message-ID: <5F622B98-A1AE-41FB-8E4A-E767DB928689@gmail.com> In-Reply-To: <201506071420.t57EKnio083109@svn.freebsd.org> References: <201506071420.t57EKnio083109@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 7, 2015, at 07:20, Marcelo Araujo <araujo@FreeBSD.org> wrote: >=20 > Author: araujo (ports committer) > Date: Sun Jun 7 14:20:48 2015 > New Revision: 284116 > URL: https://svnweb.freebsd.org/changeset/base/284116 >=20 > Log: > Include header libi386.h to silence the clang warning of implicit declara= tion > of functions biospci_*. >=20 > Differential Revision: D2668 > Reviewed by: rodrigc >=20 > Modified: > head/sys/boot/ficl/loader.c >=20 > Modified: head/sys/boot/ficl/loader.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/boot/ficl/loader.c Sun Jun 7 13:59:02 2015 (r284115) > +++ head/sys/boot/ficl/loader.c Sun Jun 7 14:20:48 2015 (r284116) > @@ -46,6 +46,7 @@ > #include "bootstrap.h" > #include <string.h> > #include "ficl.h" > +#include "../i386/libi386/libi386.h" Hi Marcelo, This commit's explicitly polluting the ficl interpreter with code from x86 o= n all platforms. Seems like the code should be refactored to not explicitly i= nclude this symbol, then #include this header there. That's the real bug.. Also, I'm not a huge fan of relative #include's. I prefer using CFLAGS with -= I (mostly personal preference, however I think it affects file generation to= o). Thanks!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5F622B98-A1AE-41FB-8E4A-E767DB928689>