Date: Wed, 23 Jul 2014 20:24:01 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, owner-src-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r268494 - in head: lib/libsbuf sys/kern sys/sys Message-ID: <20140723172401.GK93733@kib.kiev.ua> In-Reply-To: <20140721090718.GC51328@ptrcrt.ch> References: <201407101308.s6AD8pbR080041@svn.freebsd.org> <f964663ce71f8554198c1a8fc2ccda60@shatow.net> <20140721090718.GC51328@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
--v3W/iicSVFo10VrQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 21, 2014 at 11:07:18AM +0200, Pietro Cerutti wrote: > On 2014-Jul-18, 18:47, Bryan Drewery wrote: > > On 2014-07-10 08:08, Pietro Cerutti wrote: > > > Author: gahr (ports committer) > > > Date: Thu Jul 10 13:08:51 2014 > > > New Revision: 268494 > > > URL: http://svnweb.freebsd.org/changeset/base/268494 > > >=20 > > > Log: > > > Implement Short/Small String Optimization in SBUF(9) and change=20 > > > lengths and > > > positions in the API from ssize_t and int to size_t. > > >=20 > > > CR: D388 > > > Approved by: des, bapt > > >=20 > > > Modified: > > > head/lib/libsbuf/Makefile > > > head/sys/kern/subr_sbuf.c > > > head/sys/sys/sbuf.h > > >=20 > > > Modified: head/lib/libsbuf/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/lib/libsbuf/Makefile Thu Jul 10 13:04:52 2014 (r268493) > > > +++ head/lib/libsbuf/Makefile Thu Jul 10 13:08:51 2014 (r268494) > > > @@ -4,7 +4,7 @@ LIB=3D sbuf > > > SHLIBDIR?=3D /lib > > > SRCS=3D subr_sbuf.c > > >=20 > > > -SHLIB_MAJOR =3D 6 > > > +SHLIB_MAJOR =3D 7 > > >=20 > > > SYMBOL_MAPS=3D ${.CURDIR}/Symbol.map > > > VERSION_DEF=3D ${.CURDIR}/Version.def > > >=20 > >=20 > > We have symbol versioning in libsbuf. Shouldn't need to bump the=20 > > version. Just need to add a compat function for everything. It would be= =20 > > a lot of work, but bumping for ssize_t->size_t seems gratuitous to me. >=20 > The bump was due mainly to the addition of the s_static_buf field to the > sbuf struct. So, how this invalidates the point of not breaking the ABI ? We do not bump .so version for versioned libraries. For all symbols (functions) which are affected by the change, the compat shims in the old namespace must be provided. --v3W/iicSVFo10VrQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTz++wAAoJEJDCuSvBvK1B/7IP/22/rvsIve8yhBQ/2nK6QCFI aziItiWb7HXrEQceyEGkfYzbY/ISSTQaZFvUatHwwTs+SRVr7HWsVgvmu27Jr6ne IVo+lhhNRUYWzwAmfrrdfTDQGAJMHymnp+zv0Zfi2vwZyBRcUk8BmkrKj/AQD3Mm goQBoVs6queTJ7jabD/t9kVl9xieg2p2VoD6/UZog03Kh/+oNyia9Xby9bHvEx2P 0nyeYSK8tru9nlXR5/oe7qcYN/WxneIvy8eSiN+o5cRNqP2l2okWQ1WziL00rlt+ t77DrWkJ2B1JWmpHRbRCjaPFzGxjehWC2qcvvEOZno8a6EiMsh/WOlay+GFRI+95 G/0ToY1ic/Xid5PDGvPj8k0PABPmaUyGGCs9xXjdWxedZv1tOzX5KjrH1vLZyPNw 7PSzzxDv2SYlqrcRz6lb3U7PWrhH5IufIa7mTXjT+J6IarQSCDsv75mVkhbwakob p5DCsWP75ck64PSPR/JzHVHvCJdL6u8/SPcmWB1gyvkQepIuJCUBVWQzo52y9NOS QOfNbHB69cAsQ2vXJLd0rpuHzA517colVPbYMnU2bfBw4HwsIhc2+XOy3AuxsCC3 fgX1d/jSP2TsXDrctlItShYKlN041droRSp1kcsl0/5aKru12VF2QLFfqs9Uo2Tn UQKGR0SFoIuCVwCrRyQi =edN7 -----END PGP SIGNATURE----- --v3W/iicSVFo10VrQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140723172401.GK93733>