Date: Thu, 26 Sep 2002 16:20:08 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make parse.c Message-ID: <20020926162008.A33566@FreeBSD.org> In-Reply-To: <20020926231005.GS10532@wantadilla.lemis.com>; from grog@FreeBSD.org on Fri, Sep 27, 2002 at 08:40:05AM %2B0930 References: <200209260644.g8Q6iUiv000195@freefall.freebsd.org> <20020926085038.GB9743@sunbay.com> <20020926231005.GS10532@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: Greg 'groggy' Lehey <grog@FreeBSD.org> [ Data: 2002-09-26 ] [ Subjecte: Re: cvs commit: src/usr.bin/make parse.c ] > On Thursday, 26 September 2002 at 11:50:38 +0300, Ruslan Ermilov wrote: > > As an aside. Our make(1) suffers from the parsing bug in > > parse.c:ParseReadLine(). When it sees a colon (`:') it > > marks the line as being a "dependency" line, and when it > > later sees a semicolon (`;') it replaces it by a newline. > > The net effect is that the following fragment blows up: > > > > ... > > > > In OpenBSD, this has been fixed yet in 2001 by the new parsing code > > (parse.c,v 1.59 and related changes). > > What's stopping you from importing the fix? Greg, OpenBSD make(1) is largely rewritten and the parser is so very different, that this is addressed, but there are many other changes, and you know, it likely won't support one or two things we need. -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020926162008.A33566>