Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Dec 2009 19:15:48 +0000 (GMT)
From:      Iain Hibbert <plunky@rya-online.net>
To:        Matthias Drochner <m.drochner@googlemail.com>
Cc:        freebsd-bluetooth@freebsd.org
Subject:   Re: patch to make obexapp work with BSD iconv(3)
Message-ID:  <1259694948.961003.27487.nullmailer@galant.ukfsn.org>
In-Reply-To: <20091201125054.44a00147@zelz27>
References:  <20091201125054.44a00147@zelz27>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 1 Dec 2009, Matthias Drochner wrote:

>  iconv_open(3), this is more robust than trying to interpret
>  the locale string

btw nl_langinfo(3) is defined to always return a valid pointer, so the

	if (locale == NULL)
		return (-1);

is not required..

also, the locale variable can be private to obexapp_util_locale_init() as
it is not used elsewhere

regards,
iain





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1259694948.961003.27487.nullmailer>