Date: Fri, 12 Aug 2016 21:52:19 +0200 From: Ed Schouten <ed@nuxi.nl> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Ngie Cooper <yaneurabeya@gmail.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304011 - head/libexec/rtld-elf Message-ID: <CABh_MKn-8JyQK%2Bj-BzMQbPJTDPrKFWfuZXDDkAuTmTuue6dsZA@mail.gmail.com> In-Reply-To: <20160812193539.GR83214@kib.kiev.ua> References: <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> <20160812183636.GP83214@kib.kiev.ua> <CABh_MK=RT=1rm_RDY3-9eoYiybfwmHEeU_DRvOuNnTpPV_R0Fg@mail.gmail.com> <20160812193539.GR83214@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Kostik, 2016-08-12 21:35 GMT+02:00 Konstantin Belousov <kostikbel@gmail.com>: > What is improper about the tail-queue for global object list ? > Typical operations with it involve all objects in the list. The only > special ops I am aware are lookups by name or by dev_t/inode, but having > the parallel (two) maps there is overkill. Nothing! That's all good. :-) All I wanted to say is that I think that it's a pity that <sys/queue.h> provides macros that implement operations that can only be implemented with a suboptimal time complexity. A good example is SLIST_REMOVE(). In my opinion, it shouldn't exist in the first place. As soon as you need it, you should have very likely used LIST_*() instead. It would be nice if we could at one point get rid of those bad macros, but I guess I may be too optimistic about that. -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKn-8JyQK%2Bj-BzMQbPJTDPrKFWfuZXDDkAuTmTuue6dsZA>