Date: Tue, 8 Dec 2020 11:25:38 -0600 From: Jason Bacon <bacon4000@gmail.com> To: Kyle Evans <kevans@freebsd.org>, "Jason W. Bacon" <jwb@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r557295 - in head/sysutils/slurm-wlm: . files Message-ID: <24d4b659-636b-770a-0cf8-8cc71a730270@gmail.com> In-Reply-To: <e6376ef8-0559-5f1e-eb5f-fb8414a991e3@gmail.com> References: <202012081621.0B8GLGu7011665@repo.freebsd.org> <CACNAnaHhC5bKgQUpOT0vgbd%2BXbd%2BXSx528Yyuh9mvDfy4Gmuow@mail.gmail.com> <e6376ef8-0559-5f1e-eb5f-fb8414a991e3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/8/20 10:44 AM, Jason Bacon wrote: > On 12/8/20 10:28 AM, Kyle Evans wrote: >> On Tue, Dec 8, 2020 at 10:21 AM Jason W. Bacon <jwb@freebsd.org> wrote= : >>> Author: jwb >>> Date: Tue Dec=C2=A0 8 16:21:16 2020 >>> New Revision: 557295 >>> URL: https://svnweb.freebsd.org/changeset/ports/557295 >>> >>> Log: >>> =C2=A0=C2=A0 sysutils/slurm-wlm: Back out -fno-common patches, add -f= common flag >>> >>> =C2=A0=C2=A0 Fixes runtime regression caused by r546150 >>> >>> =C2=A0=C2=A0 Reported by:=C2=A0=C2=A0=C2=A0 jrm >>> =C2=A0=C2=A0 MFH:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 2020Q4 >>> >> I guess the regression was from the patch to >> src/plugins/select/cons_tres/job_test.c and an issue somewhere without= >> slurmctld? That patch almost certainly should have made them weak >> references instead of removing them entirely, based on the comment in >> the vicinity. >> >> Thanks, >> >> Kyle Evans > It's more complicated than that.=C2=A0 I tried converting to weak refs,= but=20 > the files are linked into multiple executables + the use of dlopen=20 > might obscure things to the compiler/linker.=C2=A0 I'd have to review t= he=20 > rules to verify the latter. > > I'll see if upstream has made -fcommon unnecessary in the next release = > when I have time to work on an upgrade a few weeks out. > > Best, > > =C2=A0=C2=A0=C2=A0 JB > I do wonder why a team doing mass updates would take a risky approach=20 like back-porting changes from a later upstream commit, rather than the=20 safer approach of just enabling -fcommon.=C2=A0 I think source patches li= ke=20 this should generally be left to upstream or maintainers, who are more=20 likely to take the time to fully test them. I appreciate all the work that people put into these mass fixes but=20 would suggest being as conservative as possible with them. Best, =C2=A0=C2=A0=C2=A0 JB --=20 Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24d4b659-636b-770a-0cf8-8cc71a730270>