Date: Wed, 15 Aug 2018 00:09:00 +0800 From: blubee blubeeme <gurenchan@gmail.com> To: Mathieu Arnold <mat@freebsd.org> Cc: Helen Koike <helen.koike@collabora.com>, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: workflow question: how do you maintain the port in sync with upstream? Message-ID: <CALM2mEmD6epXhfFseEFOSdSz5-7aHEdDvt8WQ1krk9Ue4_vGbg@mail.gmail.com> In-Reply-To: <20180814153338.bujxg3a5uswj3y5n@ogg.in.absolight.net> References: <05457c2b-b85c-a929-20e7-38ff1b2899d6@collabora.com> <CALM2mEmnrLmLApeuun9h2OPJbj_wMXY9u-q=PUGyNpy5w8XfQg@mail.gmail.com> <87211ccd-bb2f-cd03-ecde-fd123d0c9ca5@collabora.com> <CALM2mEkV-pyQneSiSrWuBQ2VxoM-UAADSDjm5o2HhjD4FWBQYA@mail.gmail.com> <c0e1f68d-d1c7-b74d-b058-d758f46a7e1b@collabora.com> <CALM2mE=hXWocn8DDA23Qy6SEaFZg6OtoAQsAYWwhzc5eObwGpA@mail.gmail.com> <20180814153338.bujxg3a5uswj3y5n@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 14, 2018 at 11:33 PM Mathieu Arnold <mat@freebsd.org> wrote:
> On Tue, Aug 14, 2018 at 10:41:43PM +0800, blubee blubeeme wrote:
> > This one is fairly straight forward, you can simply replace that string
> > with a regex command;
> > This is an example of running a replace command for strings after the
> patch
> > phase of the build;
> >
> > post-patch:
> > @${REINPLACE_CMD} -e 's|for Linux|for FreeBSD|g' ${WRKSRC}/README
>
> Patching files in post-patch using sed SHOULD only be used to replace
> dynamic content, never static content.
>
This is missing the point of the email since you can call that command in
any stage of the port build process.
Maybe we could append this info to the porters handbook.
>
> --
> Mathieu Arnold
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALM2mEmD6epXhfFseEFOSdSz5-7aHEdDvt8WQ1krk9Ue4_vGbg>