Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Aug 2006 16:32:30 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-current@freebsd.org
Cc:        Jun Kuriyama <kuriyama@imgsrc.co.jp>
Subject:   Re: INVARIANTS in sys/sys/sx.h
Message-ID:  <200608291632.30992.jhb@freebsd.org>
In-Reply-To: <7m3bbhx6vc.wl%kuriyama@imgsrc.co.jp>
References:  <7m3bbhx6vc.wl%kuriyama@imgsrc.co.jp>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 28 August 2006 10:38, Jun Kuriyama wrote:
> 
> I found this when I compiled my kernel with INVARIANTS without
> INVARIANT_SUPPORT.
> 
> In src/sys/sys/sx.h, _sx_assert() is defined in INVARIANT_SUPPORT,
> 
> > #ifdef INVARIANT_SUPPORT
> > void	_sx_assert(struct sx *sx, int what, const char *file, int line);
> > #endif
> 
> but sx_assert() uses this function in INVARIANTS option.
> 
> > #ifdef INVARIANTS
> > #define	sx_assert(sx, what)	_sx_assert((sx), (what), LOCK_FILE, LOCK_LINE)
> > #else
> > #define	sx_assert(sx, what)
> > #endif
> 
> Is this consistent?

It's a bug, sorry.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608291632.30992.jhb>