Date: Fri, 26 Apr 2019 11:21:41 -0500 From: Justin Hibbits <jhibbits@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346588 - head/lib/libc/powerpc64/string Message-ID: <20190426112141.78632e17@titan.knownspace> In-Reply-To: <20190423102442.GA86961@FreeBSD.org> References: <201904230253.x3N2rrrh041288@repo.freebsd.org> <20190423102442.GA86961@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 23 Apr 2019 10:24:42 +0000 Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Apr 23, 2019 at 02:53:53AM +0000, Justin Hibbits wrote: > > New Revision: 346588 > > URL: https://svnweb.freebsd.org/changeset/base/346588 > > > > Log: > > powerpc64: Rewrite strcmp in asm to take advantage of word size > > ... > > Some performance gain rates between the current and the optimized > > solution: > > > > String size (bytes) Gain rate > > <=8 0.59% > > <=16 1.92% > > 32 3.02% > > 64 5.60% > > 128 10.16% > > 256 18.05% > > 512 30.18% > > 1024 42.82% > > Nice! This should help to speed up buildworld quite a bit. Would it > be feasible to patch ppc32 in a similar fashion? Thanks, > > ./danfe This actually uses 'cmpb' which is only available on PowerISA 2.05+, so I'll need to pull it out for now, and re-enable it once we have ifuncs. As it stands, this commit broke the G5 and POWER4/POWER5. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190426112141.78632e17>