Date: Sun, 17 Mar 2002 18:15:40 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Robert Watson <rwatson@FreeBSD.ORG> Cc: Hiten Pandya <hitmaster2k@yahoo.com>, current@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, tanimura@r.dl.itc.u-tokyo.ac.jp Subject: Re: cvs commit: src/sys/kern kern_mtxpool.c src/sys/sys kernel.h src/sys/vm vm_fault.c vm_glue.c vm_map.c vm_map.h vm_pageout.c vm_zone.c Message-ID: <200203180215.g2I2Feh42022@apollo.backplane.com> References: <Pine.NEB.3.96L.1020317202947.13492B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:Hmm. Ok, so right now the code that has been branched for DP1 makes use
:of Brian's recent locking commits. My original thought was we'd simply
:back it out of that branch to make sure that the DP is reliable. How hard
:would it be for us to switch to what you propose (just convert all slocks
:into xlocks, and simplify out the upgrade semantics), in particular,
:before we cut the DP? It sounds to me like the right approach is simply
:to fall back to lockmgr for the DP, and get these fixes into the main tree
:and they'll be there for the next DP in a few months.
:
:Can you take ownership of the task since you clearly know what's going on?
:Can I stick your name in the smp web page saying so? :-)
:
:Robert N M Watson FreeBSD Core Team, TrustedBSD Project
:robert@fledge.watson.org NAI Labs, Safeport Network Services
I think the developers currently working on it have the expertise to
clean it up. My recommendation is that developer who committed the
SX lock stuff back it out (fall back to the lockmgr locks), and then
that same developer scan the code and determine if the lockmgr lock
can just be made exclusive for all cases and, if so, to test and
commit that. If the exclusive-only lockmgr lock works then that is
what should go into the DP, else the original lockmgr stuff should go
in.
Until the critical_*() function issue is resolved I do not want to
make extensive modifications or updates to my -current tree so I couldn't
do this stuff in the time frame you are talking about even if I wanted
to.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203180215.g2I2Feh42022>