Date: Thu, 7 Mar 2002 22:29:31 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Mark Murray <mark@grondar.za> Cc: obrien@FreeBSD.org, "M. Warner Losh" <imp@village.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307192930.GA29021@nagual.pp.ru> In-Reply-To: <200203071913.g27JD3RV038460@grimreaper.grondar.org> References: <20020307105542.A61459@dragon.nuxi.com> <200203071913.g27JD3RV038460@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 07, 2002 at 19:13:03 +0000, Mark Murray wrote: > > On Thu, Mar 07, 2002 at 04:31:22PM +0000, Mark Murray wrote: > > > > But the two constructs are different. In the prior code, if mkstemp > > > > returns -1, then fdopen wouldn't be called. In the new code it is. > > > > > > I have reverted this, folks! > > > > Thanks. I hate to ask... but I saw this type of change in other files > > besides just rwall.c. rwall.c was just the one I picked to respond to. > > I've been doing this for months. I also notice that you break 8bit cleannes of 'ls' by removing 'unsigned' from the char. I fear that this kind of change can break 8bit in other places too. Do you remember where else you make similar change? -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307192930.GA29021>