Date: Sun, 10 Oct 2004 17:41:39 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@DeepCore.dk> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: sos@FreeBSD.ORG Subject: Re: cvs commit: src/sys/geom geom_pc98.c src/sys/dev/ata ata-all.h ata-cbus.c ata-disk.c Message-ID: <41695833.3050500@DeepCore.dk> In-Reply-To: <89782.1097422612@critter.freebsd.dk> References: <89782.1097422612@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: > In message <20041009.023958.41719880.nyan@jp.FreeBSD.org>, Takahashi Yo= shihiro=20 > writes: >=20 >>In article <200410071737.i97Hb9TU038301@repoman.freebsd.org> >>S=F8ren Schmidt <sos@FreeBSD.org> writes: >> >> >>>sos 2004-10-07 17:37:09 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/geom geom_pc98.c=20 >>> sys/dev/ata ata-all.h ata-cbus.c ata-disk.c=20 >>> Log: >>> Move the PC98 specific geometry "gunk" to geom_pc98.c where it belon= gs. >>> This also adds support for bigger disks on the controller I have acc= ess to, >>> and maybe others if I understood the adhoc methods used on those. >>> =20 >>> Those with more PC98 bigdrive controllers it is hereby invited to ad= d/fix >>> support for those in geom_pc98.c and not using #ifdef PC98 all over = the place. >> >>This broke non-ATA disk supports. We need to use different way for >>geometry translation between ATA and non-ATA disks. And, your >>'BigDrive' support has some problems, it cannot use 'BigDrive' as root >>filesystem and it is incompatibility with the other OSs. >=20 >=20 > Then conditionalize the code in geom_pc98 on the provider name starting= > with "ad". I allready did so :) > All PC98 disk layout relevant code should be in geom_pc98 and not > in diskdrivers. Exactly! However there is fripe with fdisk_pc98 and sysinstall it seems, dunno=20 about those as they are way out of my territory... --=20 -S=F8ren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41695833.3050500>