Date: Sat, 12 Aug 2017 09:57:33 -0700 From: Ryan Libby <rlibby@freebsd.org> To: Ian Lepore <ian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322418 - head/lib/msun/src Message-ID: <CAHgpiFx=pDQA-dHNQJwqDQ%2B2iXJDkvVNsdmyBZG2EL%2BVJQCU4g@mail.gmail.com> In-Reply-To: <1502555191.47886.30.camel@freebsd.org> References: <201708112241.v7BMfP5X028262@repo.freebsd.org> <1502555191.47886.30.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 12, 2017 at 9:26 AM, Ian Lepore <ian@freebsd.org> wrote: > On Fri, 2017-08-11 at 22:41 +0000, Ryan Libby wrote: >> Author: rlibby >> Date: Fri Aug 11 22:41:24 2017 >> New Revision: 322418 >> URL: https://svnweb.freebsd.org/changeset/base/322418 >> >> Log: >> lib/msun: avoid referring to broken LDBL_MAX >> >> LDBL_MAX is broken on i386: >> https://lists.freebsd.org/pipermail/freebsd-numerics/2012-September >> /000288.html >> >> Gcc has produced +Infinity for LDBL_MAX on i386 and amd64 with -m32 >> for some time, and newer versions of gcc are now warning that the >> "floating constant exceeds range of 'long double'". Avoid this by >> referring to half the value of LDBL_MAX instead. >> >> Reviewed by: bde >> Approved by: markj (mentor) >> Sponsored by: Dell EMC Isilon >> > > I now get this error when building toolchain for sparc: > > cc -isystem /b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp/usr/include -L/b/staging/freebsd/head/obj/sparc64.spar > c64/b/staging/freebsd/head/src/tmp/usr/lib -B/b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp/usr/lib --sysroot=/b/ > staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp -B/b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/ > src/tmp/usr/bin -fPIC -DPIC -g -O2 -pipe -I/b/staging/freebsd/head/src/lib/msun/ld128 -I/b/staging/freebsd/head/src/lib/msun/sparc64 -I/b/sta > ging/freebsd/head/src/lib/msun/src -I/b/staging/freebsd/head/src/lib/libc/include -I/b/staging/freebsd/head/src/lib/libc/sparc64 -MD -MF. > depend.catrigl.pico -MTcatrigl.pico -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wno-pointer-sign -Wno-unknown-pragmas - > c /b/staging/freebsd/head/src/lib/msun/src/catrigl.c -o catrigl.pico > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: pasting "0x0.8p" and "(" does not give a valid preprocessing token > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: exponent has no digits > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: pasting ")" and "L" does not give a valid preprocessing token > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c: In function 'clog_for_large_values': > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310: error: expected ')' before 'L' > *** [catrigl.pico] Error code 1 Thanks, I see it. It also shows up on the sparc64 ci build [1]. Let me see if I can find a quick fix, else I guess we can just back it out for now. [1] https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/2534/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFx=pDQA-dHNQJwqDQ%2B2iXJDkvVNsdmyBZG2EL%2BVJQCU4g>