Date: Sun, 28 Sep 2008 20:44:00 +0200 From: Stefan Ehmann <shoesoft@gmx.net> To: Robert Watson <rwatson@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: ipfw: LOR/panic with uid rules Message-ID: <200809282044.01506.shoesoft@gmx.net> In-Reply-To: <alpine.BSF.1.10.0809281527540.17520@fledge.watson.org> References: <200809231851.42849.shoesoft@gmx.net> <200809262233.59216.shoesoft@gmx.net> <alpine.BSF.1.10.0809281527540.17520@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 28 September 2008 16:30:43 Robert Watson wrote: > On Fri, 26 Sep 2008, Stefan Ehmann wrote: > > > > #10 0xc07eccd6 in _rw_rlock (rw=0xc0e5acec, file=0xc103ceed > > > > "/usr/src/sys/modules/ipfw/../../netinet/ip_fw2.c", line=2020) at > > > > /usr/src/sys/kern/kern_rwlock.c:283 > > > > > > > > #11 0xc103b92a in ipfw_chk (args=0xc47328a8) at > > > > /usr/src/sys/modules/ipfw/../../netinet/ip_fw2.c:2020 > > > > > > This surprises me -- can in principle we've passed down 'inp' so there > > > should be no need to look it up. In higher frames, 'inp' is definitely > > > non-NULL, so what happened here? Could you print out the values of the > > > local variables in the check_uidgid() frame? Especially, 'inp' and > > > 'lookup'? > > > > Something seems to be broken or I'm doing something wrong. I can't access > > the locals: > > Dear Stefan: > > Could you update to ip_fw2.c:1.195? I've fixed an issue there that caused > ipfw to look up the inpcb even thought it was passed down in the case that > a TCP connection was in TIMEWAIT: No panic after ~1 hour of testing. Looks very promising. I will give it more testing when it's MFCed. Thanks for your fixes! -- Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809282044.01506.shoesoft>