Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Mar 2002 14:30:50 +0000 (GMT)
From:      Mike Silbersack <silby@silby.com>
To:        "David O'Brien" <obrien@FreeBSD.ORG>
Cc:        Mark Murray <mark@grondar.za>, <cvs-committers@FreeBSD.ORG>, <cvs-all@FreeBSD.ORG>
Subject:   Re: cvs commit: src/usr.bin/rwall rwall.c
Message-ID:  <20020307142738.U3443-100000@patrocles.silby.com>
In-Reply-To: <20020307120711.A62212@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Thu, 7 Mar 2002, David O'Brien wrote:

> On Thu, Mar 07, 2002 at 01:28:24PM +0000, Mark Murray wrote:
> > > This is by *NO* means more readable than the old code!
> >
> > I guess this comes down to an opinion, right? :-)
>
> There seems to be more NO's than agreements with you in this case.  BUT
> that does not matter.  We've operated under the "don't change things w/o
> a good reason" to (1) settle cases of opinion like this.  And (2) because
> changing things too much throws away over a decade of tested proven code.
> This is something that should not be taken lightly.  We hold our age up
> all the time as one of our advantages over Linux.  However these
> WARNS/lint runs are making our code as volatile as the GNU stuff we snub.

I believe I've asked this before, but I haven't heard a good answer:

What benefit do the WARNS changes have?

I'd understand the need for "strcpy -> strlcpy changes" or "snprintf
changes", but I don't see what good the WARNS changes are having.  Is this
documented somewhere?

Mike "Silby" Silbersack


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307142738.U3443-100000>