Date: Thu, 10 Jun 2010 11:00:50 +0400 From: Andrej Zverev <az@freebsd.org> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: cvs-ports@freebsd.org, "Philip M. Gollucci" <pgollucci@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/databases/p5-DBIx-Class Makefile Message-ID: <AANLkTikkIwNRnpEQvpNExb5PtqNihOiT1SjByJM8Yyr9@mail.gmail.com> In-Reply-To: <4C10859E.2030607@p6m7g8.com> References: <201006100139.o5A1daBR093873@repoman.freebsd.org> <AANLkTimatnpEeMNGD-sNvo3cvcs7tFTDVsDnyhm1LxqO@mail.gmail.com> <4C10859E.2030607@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 10, 2010 at 10:26 AM, Philip M. Gollucci <pgollucci@p6m7g8.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 06/10/10 06:20, Andrej Zverev wrote: >> I have a few questions. >> >> 1. Why you added DBD::SQLite back? >> This is not required except for testing (we have the support test target= ?). > hmm. =A0I think you have me here. > I was probably confused by this -- > work/DBIx-Class-0.08122/lib/DBIx/Class/Storage/DBI/SQLite.pm:(including > cascading) support for recent versions of SQLite and L<DBD::SQLite>. > > I can revert that particular change if you think its useful. Unbelievable! :) Revert everything in its place - a very correct decision. Thank you Philip, I understand everything, but what's the rush? Who needs these 50 commits where you can make some mistakes? I also make mistakes, but man .. If you feel yourself as perl@ part, I can offer assistance in review before commit. Human eye is better than Tinderbox (damn progress). > >> 2. TEST_DEPENDS - What is it? > This was an initiative started by tobez@ and others. > http://freebsd.monkey.org/freebsd-perl/200804/msg00004.html > As I had a heck of a time getting the tests to pass, I added this for > the future. > Will know. > > - -- > - -----------------------------------------------------------------------= - > 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 =A03F8C 75B8 8FFB DB9B 8C1C > Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 > VP Apache Infrastructure; Member, Apache Software Foundation > Committer, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0FreeBSD Foundat= ion > Consultant, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 P6M7G8 Inc. > Sr. System Admin, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Ridecharge Inc. > > Work like you don't need the money, > love like you'll never get hurt, > and dance like nobody's watching. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.14 (FreeBSD) > > iD8DBQFMEIWedbiP+9ubjBwRAoN1AJ4u5Cut7D0hYCgWv4v235jw1tUllQCgggei > xoj9fPt+6QiAkmtlwsrD6HU=3D > =3DRfIf > -----END PGP SIGNATURE----- >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikkIwNRnpEQvpNExb5PtqNihOiT1SjByJM8Yyr9>