Date: Mon, 17 Mar 2008 13:58:50 +0300 From: Dmitriy Kirhlarov <dimma@higis.ru> To: ports@FreeBSD.org Subject: Re: patch for net-mgmt/zabbix Message-ID: <47DE4EEA.4080802@higis.ru> In-Reply-To: <47DB5242.4040509@zsupport.ru> References: <47DB5242.4040509@zsupport.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
=E4=CD=C9=D4=D2=C9=CA =EC=CF=C8=C1=CE=D3=CB=C9=CA wrote:
>=20
> There is a path "patch-src__libs__zbxcomms__comms.c"
>=20
> --- src/libs/zbxcomms/comms.c.orig 2008-03-15 07:23:00.000000000 +=
0300
> +++ src/libs/zbxcomms/comms.c 2008-03-15 07:24:09.000000000 +0300
> @@ -698,7 +698,7 @@
>=20
> for(i =3D 0; i < s->num_socks; i++) {
> #if !defined(_WINDOWS)
> - if(s->sockets[i] > n)
> + if(s->sockets[i] + 1 > n)
> n =3D s->sockets[i] + 1;
> #endif
> if(FD_ISSET(s->sockets[i], &sock_set))
>=20
>=20
> As I know, in select(ndfs, ...), ndfs must be max descriptor + 1.
> So, zabbix have a little bug, some connections in zbx_tcp_accept() will=
=20
> be not accepted,
> because their socket descriptors are not in the ndfs.
>=20
> This patch resolve troubles with "ZBX_TCP_READ() failed [Interrupted=20
> system call]" issue
> from http://www.zabbix.com/forum/showthread.php?t=3D8870&mode=3Dlinear =
and=20
> other related.
svn diff svn://svn.zabbix.com/tags/1.4.4/src/libs/zbxcomms/comms.c=20
svn://svn.zabbix.com/branches/1.4/src/libs/zbxcomms/comms.c
1.4.4 already have your patch, but 1.4 brunch haven't.
Please, contact with developers over http://www.zabbix.com/forum
WBR.
Dmitriy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47DE4EEA.4080802>