Date: Fri, 2 Oct 2009 22:41:28 -0500 From: Matt <datahead4@gmail.com> To: Dima Panov <Fluffy@fluffy.khv.ru> Cc: freebsd-ports-bugs@freebsd.org, freebsd-gnats-submit@freebsd.org Subject: Re: ports/139315: [MAINTAINER] audio/liblastfm - fix build with custom PREFIX Message-ID: <cd6b4a5b0910022041m310d1329mc974a766fadf8742@mail.gmail.com> In-Reply-To: <200910031040.28375.Fluffy@fluffy.khv.ru> References: <200910021923.n92JNGb5022670@www.freebsd.org> <200910031040.28375.Fluffy@fluffy.khv.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 2, 2009 at 6:40 PM, Dima Panov <Fluffy@fluffy.khv.ru> wrote:
> On Saturday 03 October 2009 06:23:16 Matt Tosto wrote:
>> >Number: =A0 =A0 =A0 =A0 139315
>
>>
>> Build failed when custom PREFIX was set due to an incorrect formatting o=
f
>> =A0the CONFIGURE_ARGS in the port Makefile. =A0Small attached patch corr=
ects
>> =A0this issue. =A0I'm not entirely sure if ${PREFIX} or ${LOCALBASE} is =
the
>> =A0proper substitution to use in the Makefile. =A0Confirmation of this w=
ould be
>> =A0appreciated.
>>
>> Patch attached with submission follows:
>>
>> diff -U3 -r ../liblastfm/Makefile /usr/ports/audio/liblastfm/Makefile
>> --- ../liblastfm/Makefile =A0 =A0 2009-10-01 10:44:58.000000000 -0500
>> +++ /usr/ports/audio/liblastfm/Makefile =A0 =A0 =A0 2009-09-08 08:45:41.=
000000000 -0500
>> @@ -23,7 +23,7 @@
>> =A0QT_COMPONENTS=3D =A0 =A0 =A0 corelib xml network sql gui qtestlib \
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 qmake_build moc_build rcc_build uic_build
>> =A0HAS_CONFIGURE=3D =A0 =A0 =A0 yes
>> -CONFIGURE_ARGS+=3D =A0 =A0 --prefix ${LOCALBASE} --release
>> +CONFIGURE_ARGS+=3D =A0 =A0 -release
>> =A0MAKE_JOBS_UNSAFE=3D =A0 =A0yes
>>
>> =A0USE_LDCONFIG=3D =A0 =A0 =A0 =A0yes
>
> Patch reversed, right?
Oops - yes. Patch reversed. Sorry!
>
> Args order also had a side effect.
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cd6b4a5b0910022041m310d1329mc974a766fadf8742>