Date: Thu, 4 Aug 2005 14:07:47 +0100 From: "Liam J. Foy" <liamfoy@sepulcrum.org> To: Bob Willcox <bob@immure.com> Cc: Ollivier Robert <roberto@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c Message-ID: <20050804130747.GA734@anarion> In-Reply-To: <20050804122313.GA87318@luke.immure.com> References: <200505261057.j4QAv4oU071149@repoman.freebsd.org> <20050804122313.GA87318@luke.immure.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> This change causes NIS /etc/group entries (+ in column one) to be
> flagged in error. There is a PR (bin/82325) open on this with a proposed
> fix, but here is a simpler (almost) one-line version that I'm using:
>
> Index: chkgrp.c
> ===================================================================
> RCS file: /usr/cvs/FreeBSD/src/usr.sbin/chkgrp/chkgrp.c,v
> retrieving revision 1.9
> diff -u -r1.9 chkgrp.c
> --- chkgrp.c 26 May 2005 10:57:03 -0000 1.9
> +++ chkgrp.c 4 Aug 2005 12:11:03 -0000
> @@ -106,7 +106,8 @@
> }
>
> for (cp = f[0] ; *cp ; cp++) {
> - if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-') {
> + if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-' &&
> + (cp > f[0] || *cp != '+')) {
> warnx("%s: line %d: '%c' invalid character", gfn, n, *cp);
> e++;
> }
>
> Maybe someone has the time to commit a fix for this??
>
> Thanks,
> Bob
Thanks Bob. I'll commit it to dfbsd too.
Cheers,
--
- Liam J. Foy
liamfoy@sepulcrum.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050804130747.GA734>