Date: Thu, 31 Jan 2008 13:00:05 GMT From: Jaakko Heinonen <jh@saunalahti.fi> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/120055: [linux] kdump(1) segfaults on freebsd6_mmap syscall Message-ID: <200801311300.m0VD05DZ073658@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/120055; it has been noted by GNATS.
From: Jaakko Heinonen <jh@saunalahti.fi>
To: bug-followup@FreeBSD.org, patpr@davenulle.org
Cc:
Subject: Re: bin/120055: [linux] kdump(1) segfaults on freebsd6_mmap syscall
Date: Thu, 31 Jan 2008 14:57:19 +0200
--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
This is a duplicate of kern/119564. (You should use devel/linux_kdump
port for Linux binaries.) However I think that it might be reasonable to
commit the attached patch to avoid kdump segfaulting on "corrupted"
dumps.
--6TrnltStXW4iwmi0
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="kdump_segfault.diff"
Index: kdump.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/kdump/kdump.c,v
retrieving revision 1.39
diff -u -r1.39 kdump.c
--- kdump.c 7 Jan 2008 18:50:25 -0000 1.39
+++ kdump.c 31 Jan 2008 12:46:35 -0000
@@ -770,7 +770,7 @@
narg--;
}
}
- while (narg) {
+ while (narg > 0) {
print_number(ip,narg,c);
}
(void)putchar(')');
--6TrnltStXW4iwmi0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801311300.m0VD05DZ073658>