Date: Sat, 25 Oct 2008 19:16:15 +0400 (MSD) From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: FreeBSD-gnats-submit@FreeBSD.org Cc: votdev@gmx.de Subject: ports/128368: [PATCH] net/ushare: fix build on 6.1 Message-ID: <20081025151615.A1A891702D@hades.panopticon> Resent-Message-ID: <200810251520.m9PFK1kk022784@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 128368
>Category: ports
>Synopsis: [PATCH] net/ushare: fix build on 6.1
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 25 15:20:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Marakasov
>Release: FreeBSD 7.0-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #1: Wed Jun 25 15:36:22 MSD 2008
>Description:
I've got a report of build failure on FreeBSD 6.1 (althrough it built fine in my tinderbox on 6.3, 7.0 and current):
---
...
gmake[1]: Entering directory `/usr/ports/net/ushare/work/ushare-1.1a/src'
cc -I.. -MM -O2 -fno-strict-aliasing -pipe cds.c cms.c msr.c http.c presentation.c metadata.c mime.c services.c buffer.c util_iconv.c content.c cfgparser.c trace.c redblack.c osdep.c ctrl_telnet.c ushare.c 1>.depend
cds.c:23:23: upnp/upnp.h: No such file or directory
cds.c:24:28: upnp/upnptools.h: No such file or directory
cms.c:23:23: upnp/upnp.h: No such file or directory
...
---
The cause is incorrect passing of CFLAGS to configure, the attached patch fixes the problem.
Port maintainer (votdev@gmx.de) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- ushare-1.1a.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/net/ushare/Makefile,v
retrieving revision 1.12
diff -u -u -r1.12 Makefile
--- Makefile 23 Oct 2008 12:39:25 -0000 1.12
+++ Makefile 25 Oct 2008 11:25:00 -0000
@@ -20,8 +20,9 @@
USE_GMAKE= yes
USE_GNOME= pkgconfig
USE_GETTEXT= yes
-CONFIGURE_ENV+= CFLAGS="${PTHREAD_LIBS} -I${LOCALBASE}/include -I${WRKSRC}" \
- LDFLAGS="-L${LOCALBASE}/lib -lintl"
+CONFIGURE_ENV+= LDFLAGS="-L${LOCALBASE}/lib -lintl"
+
+CFLAGS+= -I${LOCALBASE}/include -I${WRKSRC}
PLIST_FILES= bin/${PORTNAME} etc/${PORTNAME}.conf.sample etc/rc.d/${PORTNAME}
MAN1= ${PORTNAME}.1
--- ushare-1.1a.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081025151615.A1A891702D>