Date: Tue, 28 Sep 2004 12:23:10 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Matthias Andree <ma@dt.e-technik.uni-dortmund.de> Cc: Matthias Andree <matthias.andree@web.de> Subject: Re: bin/72138: libc.so.5 isn't installed in a safe way Message-ID: <20040928092310.GC15848@ip.net.ua> In-Reply-To: <m31xgmzt34.fsf@merlin.emma.line.org> References: <20040927224353.845381B217@merlin.emma.line.org> <20040928043351.GA2400@frontfree.net> <20040928071758.GB14942@ip.net.ua> <m31xgmzt34.fsf@merlin.emma.line.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vEao7xgI/oilGqZ+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Sep 28, 2004 at 10:38:23AM +0200, Matthias Andree wrote:
> Ruslan Ermilov <ru@FreeBSD.org> writes:
>=20
> > On Tue, Sep 28, 2004 at 12:33:51PM +0800, Xin LI wrote:
> >> (-CURRENT is cc'ed for a boarder review)
> >>=20
> >> I fell like this idea, and here is the patch for review:
> >>=20
> >> Index: Makefile
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >> RCS file: /r/ncvs/src/lib/libc/Makefile,v
> >> retrieving revision 1.52
> >> diff -u -r1.52 Makefile
> >> --- Makefile 14 May 2004 12:04:29 -0000 1.52
> >> +++ Makefile 28 Sep 2004 04:30:26 -0000
> >> @@ -16,6 +16,7 @@
> >> CFLAGS+=3D-I${.CURDIR}/include -I${.CURDIR}/../../include
> >> CFLAGS+=3D-I${.CURDIR}/${MACHINE_ARCH}
> >> CLEANFILES+=3Dtags
> >> +SHLINSTALLFLAGS+=3D -S
> >> INSTALL_PIC_ARCHIVE=3D yes
> >> PRECIOUSLIB=3D yes
> >> =20
> > I like the idea so much, that I suggest this instead:
> >
> > %%%
> > Index: bsd.lib.mk
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /home/ncvs/src/share/mk/bsd.lib.mk,v
> > retrieving revision 1.160
> > diff -u -r1.160 bsd.lib.mk
> > --- bsd.lib.mk 7 May 2004 09:58:36 -0000 1.160
> > +++ bsd.lib.mk 28 Sep 2004 07:13:18 -0000
> > @@ -187,9 +187,12 @@
> > =20
> > .if !target(install)
> > =20
> > -.if defined(PRECIOUSLIB) && !defined(NOFSCHG)
> > +.if defined(PRECIOUSLIB)
> > +.if !defined(NOFSCHG)
> > SHLINSTALLFLAGS+=3D -fschg
> > .endif
> > +SHLINSTALLFLAGS+=3D -S
> > +.endif
> > =20
> > _INSTALLFLAGS:=3D ${INSTALLFLAGS}
> > .for ie in ${INSTALLFLAGS_EDIT}
> > %%%
>=20
> I must say that although Xin's patch will certainly work well to address
> my original PR, I like Ruslan's idea better, because it appears to work
> for all precious libraries, not just libc. But there is more "precious"
> stuff, /bin, /sbin, /boot (including kernel), /rescue (I was glad I had
> the latter, otherwise my system would have been dead.)
>=20
> Using -S for the whole system might be a bit slow without softupdates
> (or async, which I do not favor) but would not be a bad idea from a
> robustness point of view which I personally prefer.
>=20
FWIW, I don't believe that using -S adds much overhead, no.
You can check it easily, by doing two installworlds, one with
INSTALL=3D"install -S", and one without it.
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--vEao7xgI/oilGqZ+
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBWS1+qRfpzJluFF4RAq7ZAKCUTL7DpRNDG+iGU2TM2cfpCaPe6wCglTSc
5h8UTd+lqsYWEAYNKcu8TyA=
=9Sgu
-----END PGP SIGNATURE-----
--vEao7xgI/oilGqZ+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040928092310.GC15848>