Date: Tue, 21 Oct 2014 23:45:45 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik <mjg@FreeBSD.org> Subject: Re: svn commit: r273400 - in head/sys: kern sys Message-ID: <20141021214545.GC28763@dft-labs.eu> In-Reply-To: <50143173-0319-45C0-A00E-AD2AA303C65D@FreeBSD.org> References: <201410211902.s9LJ2RoA031960@svn.freebsd.org> <50143173-0319-45C0-A00E-AD2AA303C65D@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 21, 2014 at 09:40:38PM +0000, Bjoern A. Zeeb wrote: > > On 21 Oct 2014, at 19:02 , Mateusz Guzik <mjg@FreeBSD.org> wrote: > > > Author: mjg > > Date: Tue Oct 21 19:02:26 2014 > > New Revision: 273400 > > URL: https://svnweb.freebsd.org/changeset/base/273400 > > > > Log: > > Rename sysctl_lock and _unlock to sysctl_xlock and _xunlock. > > You are perfectly describing what you are doing, but I’d also like to understand the “why?” > First off, these function do lock sysctl exclusively, so I find this to be a better suited name. In https://svnweb.freebsd.org/base?view=revision&revision=273401 I added shared locking to sysctl and this change "coincidently" freed up a nice name for a functions which remember previous lock type and lock it the same way later. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141021214545.GC28763>