Date: Thu, 31 Jan 2008 11:29:01 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: mav@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph netgraph.h ng_base.c ng_iface.c Message-ID: <20080131.112901.803599757.imp@bsdimp.com> In-Reply-To: <200801310851.m0V8pmNB093625@repoman.freebsd.org> References: <200801310851.m0V8pmNB093625@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200801310851.m0V8pmNB093625@repoman.freebsd.org>
Alexander Motin <mav@FreeBSD.org> writes:
: Implement stack protection based on GET_STACK_USAGE() macro.
: This fixes system panics possible with complicated netgraph setups
: and allows to avoid unneded extra queueing for stack unwrapping.
How does this help? What are the units? The code is almost entirely
opaque given its magic numbers (100? 64?). Also, if you are checking
to see if the stack usage is too big, it may already be too late.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080131.112901.803599757.imp>