Date: Tue, 22 Nov 2016 11:12:20 +0100 From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r426759 - in head/databases/xapian-core: . files Message-ID: <86oa17lt6j.fsf@FreeBSD.org> In-Reply-To: <b951b86f-d619-3d85-fbbf-e2dfeba2e22e@FreeBSD.org> (Mathieu Arnold's message of "Tue, 22 Nov 2016 00:17:53 %2B0100") References: <201611212126.uALLQxT0063108@repo.freebsd.org> <b951b86f-d619-3d85-fbbf-e2dfeba2e22e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> writes: > Le 21/11/2016 =C3=A0 22:26, Raphael Kubo da Costa a =C3=A9crit : > >> SOCK_CLOEXEC was introduced in FreeBSD 10, so define it to 0 on FreeBS= D 9 (the >> code already handles this case). Xapian 1.4 has a safesyssocket.h that= does the >> same thing. > > But FreeBSD 10 is not 1000000. In that case, according to > sys/sys/socket.h's log, it was added in r248534, the closest version is > 1000031. I tried looking for a specific entry mentioning SOCK_CLOEXEC in the porter's handbook and decided to go with 1000000 after not finding anything. I'm fine with adjusting the check, but given 1000031 predates even the branching of FreeBSD 10 and the minimum 10.x version we currently support is 10.1, does it make sense to do that?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86oa17lt6j.fsf>