Date: Tue, 4 Apr 2017 09:53:34 -0400 From: Ed Maste <emaste@freebsd.org> To: Kyle Evans <kevans91@ksu.edu> Cc: Andrey Chernov <ache@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316477 - head/usr.bin/grep Message-ID: <CAPyFy2Augn%2B1r41O%2B-uX5Vz8mwaPK5LZMj5Geij-61cb-MSxfA@mail.gmail.com> In-Reply-To: <CACNAnaH3LQZZ03gDE6DDAGrKQSmbWo3m=e5h247LpxmbkB74TQ@mail.gmail.com> References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> <CACNAnaH3LQZZ03gDE6DDAGrKQSmbWo3m=e5h247LpxmbkB74TQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 April 2017 at 09:09, Kyle Evans <kevans91@ksu.edu> wrote: > > This is where it gets kind of finnicky, and I'll step out and let others > weigh in -- the test I refer to was specifically written by me > (https://reviews.freebsd.org/D10112), and it's entirely to make it easier > for me to check and quantify to others where we're actually regressing or > improving as I continue fixing things in bsdgrep(1). In this case I'd rather we remove the 00 and have the test verify that. I think it's fine if there are a few tests that fail when run with GNU grep where it has the undesired, differing behaviour.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Augn%2B1r41O%2B-uX5Vz8mwaPK5LZMj5Geij-61cb-MSxfA>