Date: Wed, 01 Jun 2016 20:22:05 +0200 From: Jan Beich <jbeich@vfemail.net> To: Rusmir Dusko <nemysis@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416248 - head/games/asteroid Message-ID: <a8j4-7os2-wny@vfemail.net> In-Reply-To: <201606011601.u51G1qs7021344@repo.freebsd.org> (Rusmir Dusko's message of "Wed, 1 Jun 2016 16:01:52 %2B0000 (UTC)") References: <201606011601.u51G1qs7021344@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Rusmir Dusko <nemysis@FreeBSD.org> writes:
> --- head/games/asteroid/Makefile Wed Jun 1 15:35:42 2016 (r416247)
> +++ head/games/asteroid/Makefile Wed Jun 1 16:01:52 2016 (r416248)
> @@ -6,7 +6,7 @@ PORTVERSION=3D 1.2.1
> PORTREVISION=3D 3
> CATEGORIES=3D games
>=20=20
> -MAINTAINER=3D ports@FreeBSD.org
> +MAINTAINER=3D nemysis@FreeBSD.org
> COMMENT=3D Modern version of the arcade classic Asteroid
>=20=20
> LICENSE=3D GPLv3
> @@ -14,12 +14,12 @@ LICENSE_FILE=3D ${WRKSRC}/COPYING
>=20=20
> USE_GITHUB=3D yes
> GH_ACCOUNT=3D chazomaticus
> -GH_TAGNAME=3D ffeb0fd
> +GH_TAGNAME=3D 64869df
Defining GH_TAGNAME is undesirable as it may lead to a situation where
the port is updated without affecting PORTVERSION or PORTREVISION like here.
Maybe switch to |git describe --tags| distfile style (see attached patch).
>=20=20
> USES=3D cmake
> USE_GL=3D glut
> USE_SDL=3D mixer sdl
> -USE_GNOME=3D gtk20
> +USE_GNOME=3D gtk30
Dependency changes require at least PORTREVISION bump to facilitate
troubleshooting and for old tools than may not notice otherwise.
=2D-
$ pkg version -t asteroid-1.2.1_3 asteroid-1.2.1.9
<
Index: games/asteroid/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- games/asteroid/Makefile (revision 416253)
+++ games/asteroid/Makefile (working copy)
@@ -2,8 +2,8 @@
# $FreeBSD$
=20
PORTNAME=3D asteroid
=2DPORTVERSION=3D 1.2.1
=2DPORTREVISION=3D 3
+DISTVERSION=3D 1.2.1-9
+DISTVERSIONSUFFIX=3D -g64869df
CATEGORIES=3D games
=20
MAINTAINER=3D nemysis@FreeBSD.org
@@ -14,7 +14,6 @@ LICENSE_FILE=3D ${WRKSRC}/COPYING
=20
USE_GITHUB=3D yes
GH_ACCOUNT=3D chazomaticus
=2DGH_TAGNAME=3D 64869df
=20
USES=3D cmake
USE_GL=3D glut
Index: games/asteroid/distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- games/asteroid/distinfo (revision 416253)
+++ games/asteroid/distinfo (working copy)
@@ -1,2 +1,2 @@
=2DSHA256 (chazomaticus-asteroid-1.2.1-64869df_GH0.tar.gz) =3D 09646285433d=
1266f5b2c3f1f35b05c39a3314414c05bdb3bd31ae224d029d05
=2DSIZE (chazomaticus-asteroid-1.2.1-64869df_GH0.tar.gz) =3D 307544
+SHA256 (chazomaticus-asteroid-1.2.1-9-g64869df_GH0.tar.gz) =3D 9859e7283cc=
d243e01340cfc24fdb3384d4af95fa6a5d5c7bbf9a0fb9e557d33
+SIZE (chazomaticus-asteroid-1.2.1-9-g64869df_GH0.tar.gz) =3D 307587
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJXTyfNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bTT4H/jmVzSQ9f/cBAoG4dJL/hY9o
RZYAsgTHVCwaItriskAU9H7s2NYRfhZ/DV5seH15tm3FbfDVsiyZsc32q5Q5P7TY
P2ZJnBQakrOMFmv33pwrIutMUTGWKWHy/3OdYrOeLPzwqQ3jzuaB8ie0q+JCPXAf
Qu1fSWli6vEUb3BL+7Pmqvwzbn1REunKuFqOLs1SNSSmGDC8MP20azBmUTl61cAK
4M9gUrZwPA3EL6hsk6Z4CKOJsrtyyNuj1j6hjivZN+E0zw7+lTuqrgjEaZU8/+t0
H41nKx2asuD7zhovKwV1SE8r7YSTJ8RGIn57cK+e+pL/UcWFB1kdIlbaFhNYtgw=
=FNae
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a8j4-7os2-wny>