Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jan 2014 21:13:18 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Pietro Cerutti <gahr@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r339589 - head/devel/qt4-qtsolutions-soap
Message-ID:  <2760333.Zqjtp1erCq@mercury.ph.man.ac.uk>
In-Reply-To: <201401131154.s0DBsq00051868@svn.freebsd.org>
References:  <201401131154.s0DBsq00051868@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 13 Jan 2014 11:54:52 +0000Mon Jan 13 11:54:52 2014 Pietro Cerutti wrote:
> Author: gahr
> Date: Mon Jan 13 11:54:52 2014
> New Revision: 339589
> URL: http://svnweb.freebsd.org/changeset/ports/339589
> 
> Log:
>   - USE_QT must overwrite the master port's

Hi Pietro,

This solution doesn't look good for me. I think master port should be fixed
to respect slave ports. I wouldn't break your port (sorry for that), if I had
any clue that the qt4-qtsolutions-singleapplication port is used as a master
for other ports.

Cheers,
Max

> 
> Modified:
>   head/devel/qt4-qtsolutions-soap/Makefile
> 
> Modified: head/devel/qt4-qtsolutions-soap/Makefile
> ==============================================================================
> --- head/devel/qt4-qtsolutions-soap/Makefile	Mon Jan 13 11:52:48 2014	(r339588)
> +++ head/devel/qt4-qtsolutions-soap/Makefile	Mon Jan 13 11:54:52 2014	(r339589)
> @@ -3,10 +3,10 @@
>  
>  MASTERDIR=	${.CURDIR}/../qt4-qtsolutions-singleapplication
>  
> -USE_QT4=	qmake_build moc_build rcc_build uic_build network xml gui
> -
>  .include	"${MASTERDIR}/Makefile"
>  
> +USE_QT4=	qmake_build moc_build rcc_build uic_build network xml gui
> +
>  PORTNAME=	qt4-qtsolutions-soap
>  
>  MAINTAINER=	gahr@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2760333.Zqjtp1erCq>