Date: Tue, 03 Feb 2004 18:18:44 +0100 From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) To: Andre Oppermann <andre@freebsd.org> Cc: Ken Smith <kensmith@cse.Buffalo.EDU> Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile Message-ID: <xzpk7345bez.fsf@dwp.des.no> In-Reply-To: <401FD252.7F56765E@freebsd.org> (Andre Oppermann's message of "Tue, 03 Feb 2004 17:54:42 %2B0100") References: <200402030932.i139WBpQ054113@repoman.freebsd.org> <20040203112824.01dfdc99@localhost> <20040203163214.GD17960@electra.cse.Buffalo.EDU> <401FD252.7F56765E@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andre Oppermann <andre@freebsd.org> writes:
> I'm not a perl hacker so I can't really comment on the code snipped
> below but it looks strange that the first $ENV{} has the environment
> variable name in "" and the second one in '' quotes.
this has no significance.
> # The username of the committer.
> $COMMITTER =3D $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin
> || (getpwuid($<))[0] || sprintf("uid#%d",$<);
This should be
$COMMITTER =3D $ENV{'CVS_USER'} ||
die("Not invoked by CVS!\n");
DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpk7345bez.fsf>