Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 02 Nov 2016 04:47:13 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 213939] [NEW PORT] games/EmptyEpsilon: A spaceship bridge simulator game
Message-ID:  <bug-213939-13-ob0gMk4ptH@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213939-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-213939-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213939

Jan Beich (mail not working) <jbeich@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich@FreeBSD.org

--- Comment #3 from Jan Beich (mail not working) <jbeich@FreeBSD.org> ---
Comment on attachment 176359
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176359
shar archive

> XLICENSE_FILE=3D	${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
                                  ^^^^^^^^^^^^
Why not ${WRKSRC}/LICENSE ? Otherwise, maybe substitute one more word e.g.,

  -LICENSE_FILE=3D        ${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
  +LICENSE_FILE=3D        ${WRKDIR}/${GH_PROJECT}-${DISTVERSIONFULL}/LICENSE

> XLIB_DEPENDS=3D	libsfml-system.so:devel/sfml

Fixed in ports r425104, so EmptyEpsilon builds fine on 9.x. ;)

> XCMAKE_ARGS=3D	-DSERIOUS_PROTON_DIR=3D../SeriousProton-${DISTVERSIONFULL}/

To make it less fragile maybe use WRKSRC_<group> e.g.,

  -CMAKE_ARGS=3D  -DSERIOUS_PROTON_DIR=3D../SeriousProton-${DISTVERSIONFULL=
}/
  +CMAKE_ARGS=3D  -DSERIOUS_PROTON_DIR=3D"${WRKSRC_sproton}/"

> XPATCH_WRKSRC=3D	${WRKDIR}

Why? Only post-patch below touches the files outside of WRKSRC.

> Xpost-patch:
> X	@${REINPLACE_CMD} -e 's|basepath + |"${PREFIX}/share/emptyepsilon/" + b=
asepath + |' \
> X		${WRKDIR}/SeriousProton-*/src/resources.cpp
> X	@${REINPLACE_CMD} -e 's|loadFromFile("resources/"|loadFromFile("${PREFI=
X}/share/emptyepsilon/resources/"|' \
> X		${WRKDIR}/SeriousProton-*/src/postProcessManager.cpp

Can you keep letter case consistent: bin/EmptyEpsilon vs. share/emptyepsilon
vs. ~/.emptyepsilon ? If you pick lower case rename the port to match it e.=
g.,

  -PORTNAME=3D      EmptyEpsilon
  +PORTNAME=3D      emptyepsilon
  ...
  -GH_ACCOUNT=3D    daid
  +GH_TUPLE+=3D     daid:EmptyEpsilon:${DISTVERSIONFULL}

> sed 's/^X//' >games/EmptyEpsilon/pkg-descr << '930a933c75becaad7502e40f41=
a5a7c0'
> XEmptyEpsilon is a spaceship bridge simulator game.

The first line in pkg-descr can be dropped as it matches ${COMMENT} in Make=
file
and is obvious from reading the rest.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213939-13-ob0gMk4ptH>