Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Feb 2016 17:36:30 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 206939] [new port] biology/bowtie Poudriere logs attached
Message-ID:  <bug-206939-13-stf3iFW4A0@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-206939-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-206939-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206939

Raphael Kubo da Costa <rakuco@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakuco@FreeBSD.org

--- Comment #3 from Raphael Kubo da Costa <rakuco@FreeBSD.org> ---
A few comments and suggestions:

* GH_TAGNAME can be replaced with DISTVERSIONPREFIX=3Dv.
* WITH_DEBUG=3Dyes should only be set by users, you're not supposed to forc=
e a
debug version to be built by default.
* The bsd.port.{pre,post}.mk includes can be replaced by a single bsd.port.=
mk
include at the end.
* The code in Mk/bsd.sites.mk handling USE_GITHUB already takes care of
properly setting WRKSRC, so you don't need to set it in the Makefile.
* bowtie's Makefile already handles installing the *-l and *-s binaries, so=
 you
can drop that part of your do-install code (and make it a post-install targ=
et
instead).

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206939-13-stf3iFW4A0>