Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jul 2016 15:26:21 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r303147 - head/contrib/binutils/bfd
Message-ID:  <201607211526.u6LFQLkB012188@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Thu Jul 21 15:26:21 2016
New Revision: 303147
URL: https://svnweb.freebsd.org/changeset/base/303147

Log:
  binutils: fix "Bad value" error in bfd for MIPS when using -Bsymbolic.
  
  From OpenBSD's log:
  
  Inspired by https://sourceware.org/ml/binutils/2010-08/msg00333.html,
  but expressed differently so there are no GPLv3 issues.
  
  Obtained from:	OpenBSD (CVS rev. 1.7)
  MFC after:	1 month

Modified:
  head/contrib/binutils/bfd/elfxx-mips.c

Modified: head/contrib/binutils/bfd/elfxx-mips.c
==============================================================================
--- head/contrib/binutils/bfd/elfxx-mips.c	Thu Jul 21 14:17:36 2016	(r303146)
+++ head/contrib/binutils/bfd/elfxx-mips.c	Thu Jul 21 15:26:21 2016	(r303147)
@@ -4801,7 +4801,7 @@ mips_elf_create_dynamic_relocation (bfd 
   /* We must now calculate the dynamic symbol table index to use
      in the relocation.  */
   if (h != NULL
-      && (!h->root.def_regular
+      && (sec == NULL || !h->root.def_regular
 	  || (info->shared && !info->symbolic && !h->root.forced_local)))
     {
       indx = h->root.dynindx;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607211526.u6LFQLkB012188>