Date: Wed, 30 Aug 2017 17:22:50 -0400 From: Dan Langille <dan@langille.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Dan Langille <dvl@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay Message-ID: <01088B7D-A035-458C-9A23-70EA8381AE66@langille.org> In-Reply-To: <1sns-okrn-wny@FreeBSD.org> References: <201708301932.v7UJW1tH094312@repo.freebsd.org> <1sns-okrn-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 30, 2017, at 4:36 PM, Jan Beich <jbeich@FreeBSD.org> wrote: >=20 > Dan Langille <dvl@FreeBSD.org> writes: >=20 >> Author: dvl >> Date: Wed Aug 30 19:32:00 2017 >> New Revision: 448998 >> URL: https://svnweb.freebsd.org/changeset/ports/448998 >>=20 >> Log: >> Add base/port options for libpcap > [...] >> +OPTIONS_DEFINE=3D LIBPCAP_BASE LIBPCAP_PORTS > [...] >> +OPTIONS_SINGLE=3D SG1 >> +OPTIONS_SINGLE=3D LIBPCAP_BASE LIBPCAP_PORTS >=20 > _SINGLE declares a group of options, not the option themselves. > When _SINGLE is overloaded by _DEFINE the option is no longer = exclusive. >=20 > Did you forget to adjust Porter's Handbook example? So it seems, thank you. > OPTIONS_SINGLE=3D LIBPCAP > OPTIONS_SINGLE_LIBPCAP=3D LIBPCAP_BASE LIBPCAP_PORTS >=20 >> +OPTIONS_DEFAULT=3D LIBPCAP_BASE >=20 > Doesn't work if net/libpcap is installed as a dependency by another > (unrelated) port. What do you mean by doesn't work? tcpreplay will work. It will use the lib in base, and ignore the lib = provided by net/libpcap Do I misunderstand? > +LIBPCAP_PORTS_BUILD_DEPENDS=3D = ${LOCALBASE}/lib/libpcap.a:net/libpcap >> +LIBPCAP_PORTS_LIB_DEPENDS=3D libpcap.so:net/libpcap >=20 > Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS. I don't understand the .1 - did i miss another handbook item? Thank you. --=20 Dan Langille - BSDCan / PGCon dan@langille.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01088B7D-A035-458C-9A23-70EA8381AE66>