Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Mar 2015 07:45:30 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kurt Jaeger <pi@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r382799 - head/mail/rainloop
Message-ID:  <20150331074530.GA96248@FreeBSD.org>
In-Reply-To: <201503310733.t2V7XuXK025802@svn.freebsd.org>
References:  <201503310733.t2V7XuXK025802@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 31, 2015 at 07:33:56AM +0000, Kurt Jaeger wrote:
> New Revision: 382799
> URL: https://svnweb.freebsd.org/changeset/ports/382799
> 
> Log:
>   mail/rainloop: Add an OPTIONS_DEFAULT

May I ask, why MYSQL was preferred over SQLITE?

> +OPTIONS_SINGLE=	DB
> +OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE
> +OPTIONS_DEFAULT=	MYSQL

Two mistakes here: 1) wrong position of OPTIONS_* block (should be lower in
the Makefile), and 2) it duplicates existing knobs (OPTIONS_SINGLE and
OPTIONS_SINGLE_DB).

> @@ -28,7 +32,6 @@ PLIST_SUB=	VER="${RVER}" WWWOWN="${WWWOW
>  
>  OPTIONS_SINGLE=	DB
>  OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150331074530.GA96248>