Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Sep 2008 15:01:00 +0200
From:      Jeremie Le Hen <jeremie@le-hen.org>
To:        Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Cc:        Jeremie Le Hen <jeremie@le-hen.org>, Ruslan Ermilov <ru@FreeBSD.org>, freebsd-hackers@FreeBSD.org
Subject:   Creation of the NO_SSP build knob
Message-ID:  <20080908130059.GA55001@obiwan.tataz.chchile.org>
In-Reply-To: <86r67uevlr.fsf@ds4.des.no>
References:  <20080904124653.GK72107@obiwan.tataz.chchile.org> <20080904135200.GC31289@alpha.local> <86ljy857zz.fsf@ds4.des.no> <20080904141705.GL72107@obiwan.tataz.chchile.org> <86hc8w55mr.fsf@ds4.des.no> <20080904154138.GM72107@obiwan.tataz.chchile.org> <8663pbzp97.fsf@ds4.des.no> <20080905070028.GN72107@obiwan.tataz.chchile.org> <20080905140204.GA6498@edoofus.dev.vega.ru> <86r67uevlr.fsf@ds4.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
Hello Dag-Erling,

On Mon, Sep 08, 2008 at 01:16:16PM +0200, Dag-Erling Smørgrav wrote:
> Ruslan Ermilov <ru@FreeBSD.org> writes:
> > There's no possibility to easily make what you want, i.e., disable
> > SSP for some parts of the tree.  Doing it for particular makefiles
> > OTOH should be pretty easy, by starting a makefile with the
> > following two lines:
> 
> That's not "what Jeremie wants", that's what the Makefiles already do.
> Parts of the tree *can't* be built with SSP enabled, and the Makefiles
> set WITHOUT_SSP to disable it.

That's what the Makefiles already do indeed.  Please excuse me if my
english wasn't good enough to express it correctly.

You are right to say that parts of the tree can't be build with SSP
enabled.  IMHO, the problem lies in the way it's enforced: using
WITH_SSP shouldn't lead to a build error.

The patch I sent along my reply to Ruslan corrects this.

By the way, I think WITH_*/WITHOUT_* options should be user-only options
and shouldn't be used in the source tree.  This would avoid this kind of
problem.

Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080908130059.GA55001>