Date: Sat, 14 Mar 2020 02:28:02 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org>, Jason Evans <jasone@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r354606 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc Message-ID: <CAKBkRUxqF%2BtJTAEv14Lj2ncstLvUrmFMdP9raDX=hzk-gOF-zg@mail.gmail.com> In-Reply-To: <1cc79883-382f-dcad-ce0d-f8e26232e394@FreeBSD.org> References: <201911110506.xAB56nFV057050@repo.freebsd.org> <1cc79883-382f-dcad-ce0d-f8e26232e394@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think it's fine to get jemalloc 5.2.1 in again now. The previous fails were due to ancient gcc421. Now the in-tree gcc has been removed and the default compiler of non-llvm platforms are all using gcc6 from ports. The CI environment are also updated to follow the current standard. I've tested a patch combines r354605 + r355975 and it builds fine on amd64 (clang10) and mips (gcc6). Best, Li-Wen On Thu, Jan 9, 2020 at 1:45 PM Bryan Drewery <bdrewery@freebsd.org> wrote: > > Do you plan to get this back in soon? I hope to see it before 12.2 if > possible. Is there some way I can help? > > I'm interested in these changes in 5.2.1 (I think) > - Properly trigger decay on tcache destroy. (@interwq, @amosbird) > - Fix tcache.flush. (@interwq) > - Fix a side effect caused by extent_max_active_fit combined with > decay-based purging, where freed extents can accumulate and not be > reused for an extended period of time. (@interwq, @mpghf) > > I have a test case where virtual memory was peaking at 275M on 4.x, 1GB > on 5.0.0, around 750M on 5.1.0, and finally 275M again on 5.2.0. The > 5.0/5.1 versions appeared to be a widespread leak to us. > > On 11/10/2019 9:06 PM, Jason Evans wrote: > > Author: jasone > > Date: Mon Nov 11 05:06:49 2019 > > New Revision: 354606 > > URL: https://svnweb.freebsd.org/changeset/base/354606 > > > > Log: > > Revert r354605: Update jemalloc to version 5.2.1. > > > > Compilation fails for non-llvm-based platforms. > > > -- > Regards, > Bryan Drewery >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUxqF%2BtJTAEv14Lj2ncstLvUrmFMdP9raDX=hzk-gOF-zg>