Date: Wed, 12 Jun 2013 10:56:36 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, nwhitehorn@FreeBSD.org Subject: Re: svn commit: r251652 - head/release Message-ID: <20130612145636.GH1558@glenbarber.us> In-Reply-To: <20130612.234224.888649268051803264.hrs@allbsd.org> References: <20130612.230800.1862462548384264440.hrs@allbsd.org> <20130612141204.GG1558@glenbarber.us> <51B882CF.7070403@freebsd.org> <20130612.234224.888649268051803264.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--aziWXe2aaRGlkyg3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 12, 2013 at 11:42:24PM +0900, Hiroki Sato wrote: > nw> On 06/12/13 09:12, Glen Barber wrote: > nw> > On Wed, Jun 12, 2013 at 11:08:00PM +0900, Hiroki Sato wrote: > nw> >> gj> Author: gjb > nw> >> gj> Date: Wed Jun 12 13:15:28 2013 > nw> >> gj> New Revision: 251652 > nw> >> gj> URL: http://svnweb.freebsd.org/changeset/base/251652 > nw> >> gj> > nw> >> gj> Log: > nw> >> gj> Add new script to run release builds. The script is heavily b= ased > nw> >> upon > nw> >> gj> the release/generate-release.sh script by nwhitehorn. > nw> >> gj> > nw> >> gj> This script can use optional configuration file to override > nw> >> defaults, > nw> >> gj> making running multiple serialzied builds with different speci= fic > nw> >> gj> configurations or architecture-specific tunings quite easy. > nw> >> gj> > nw> >> gj> Sample overrideable options are included in the > nw> >> release.conf.sample > nw> >> gj> file. > nw> >> gj> > nw> >> gj> Approved by: kib (mentor) > nw> >> gj> MFC After: 2 weeks > nw> >> gj> X-MFC-To: stable/9 only > nw> >> > nw> >> Are you planning to replace generate-release.sh with this or kee= p the > nw> >> two scripts? > nw> >> > nw> > The plan is to eventually replace the generate-release.sh script. > nw> > > nw> > Glen > nw> > > nw> > nw> As I mentioned in a private email to Glen, it might be reasonable just > nw> to replace it now. generate-release.sh exists solely for the > nw> convenience of re@ (the main tool is just make release) and so we > nw> should just have whichever tools re@ finds more convenient. I suspect > nw> it is the new script. >=20 > I agree. Maintaining two scripts are confusing. >=20 > However, I do not think the imported version of release.sh is ready > because it has non-reasonable default values like > TARGET_ARCH=3D${TARGET}, for example. When this script was submitted > by Glen a while ago, I did not merge parts which were problematic or > difficult to maintain. >=20 In cases such as amd64 and i386, TARGET and TARGET_ARCH are set to the same value. For architectures like pc98, mips, etc., they surely will differ. However, IMHO, for these cases, that is where reading in a configuration file makes things much easier to tune per-build, rather than setting environment values. When I originally proposed these changes, buildworld with empty TARGET/TARGET_ARCH would cause the build to fail. I would need to find the thread in my email archives to remember specifically where it was broken. I can rework it so TARGET and TARGET_ARCH are only included in make(1) arguments if set if that is desired. Glen --aziWXe2aaRGlkyg3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJRuIwkAAoJEFJPDDeguUajrlEIAIC0YbQ5bCwiMbUXRfkaHPXO tCo9m1a7lE9sLkm6gI7kkJj10nc1v31BOmRtV5siiUfoF7dQm0W+D0iPz0AJuesm IrYG9GrbsKOr0lq311oIMxPjkdDMw5WUkQ+ZMfzHePF//vhHADAfIz9uY9KXwVs2 gTZZpBcKQuBqRYDCqjXh9oi9eBbQ57lFLxl334ncNiC60J+gwEBFf9q7FNzJ0hq/ YKBCRy78hh9NXZDibsX8qN1C8hSGQreM/3YailfrNtnvdm7GGihbsV4SLIyCezhb udIACtfarwCEU4V01+3z23+Kd8AumykYtsbRshM7A9NVREisYNvMahswo2+y8Xg= =WdH4 -----END PGP SIGNATURE----- --aziWXe2aaRGlkyg3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130612145636.GH1558>