Date: Fri, 29 Nov 2002 13:48:27 -0800 (PST) From: Mikko Tyolajarvi <mikkot@pacbell.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: sec@42.org Subject: ports/45841: [patch] x11-wm/wmx compile and run-time errors on 5.0 Message-ID: <20021129134331.S321-100000@atlas.home>
next in thread | raw e-mail | index | archive | help
>Number: 45841
>Category: ports
>Synopsis: [patch] x11-wm/wmx compile and run-time errors on 5.0
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Nov 29 13:50:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Mikko Tyolajarvi
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD sotec.home 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Thu Nov 28 15:19:11 PST 2002 mikko@sotec.home:/usr/obj/usr/src/sys/SOTEC i386
% gcc --version
gcc (GCC) 3.2.1 [FreeBSD] 20021009 (prerelease)
>Description:
Port won't compile. Generates X-errors and window decorations get
messed up.
>How-To-Repeat:
Problem 1: compiling
% cd /usr/ports/x11-wm/wmx
% make
[...]
c++ -c -O -pipe -mcpu=pentiumpro -I/usr/X11R6/include Menu.C
Menu.C:592: default argument given for parameter 3 of `
CommandMenu::CommandMenu(WindowManager*, XEvent*, char* = 0)'
Menu.h:72: after previous specification in `
CommandMenu::CommandMenu(WindowManager*, XEvent*, char* = 0)'
*** Error code 1
Stop in /usr/ports/x11-wm/wmx/work/wmx-5sec6.
*** Error code 1
Stop in /usr/ports/x11-wm/wmx.
Patch included below.
Problem 2:
The "active" border and the close button are drawn incorrectly or
not at all. Wmx logs errors like:
wmx: <request-code-128> (0x800023): BadMatch (invalid parameter attributes)
This can be reproduced on -STABLE as well, with MALLOC_OPTIONS=J.
Patch with workaround included below.
>Fix:
Fix 1:
% cat patch-Menu.C
--- Menu.C.org Fri Nov 29 12:25:19 2002
+++ Menu.C Fri Nov 29 12:26:57 2002
@@ -588,7 +588,7 @@
CommandMenu::CommandMenu(WindowManager *manager, XEvent *e,
- char* otherdir = NULL)
+ char* otherdir)
: Menu(manager, e)
{
const char *home = getenv("HOME");
Fix 2:
% cat patch-Border.C
--- Border.C.orig Sat May 15 15:54:18 1999
+++ Border.C Fri Nov 29 13:03:51 2002
@@ -631,11 +631,10 @@
}
int final = rl.count();
- rl.append(rl.item(final-1));
- rl.item(final).x -= 1;
- rl.item(final).y += rl.item(final).height;
- rl.item(final).width += 1;
- rl.item(final).height = h - rl.item(final).height + 2;
+ rl.append(rl.item(final-1).x - 1,
+ rl.item(final-1).y + rl.item(final-1).height,
+ rl.item(final-1).width + 1,
+ h - rl.item(final-1).height + 2);
XShapeCombineRectangles(display(), m_parent, ShapeBounding,
0, 0, rl.xrectangles(), rl.count(),
$.02,
/Mikko
Mikko Tyolajarvi___________________________________________mikkot@pacbell.net
>Release-Note:
>Audit-Trail:
>Unformatted:
To: FreeBSD-gnats-submit@freebsd.org
From: Mikko Tyolajarvi <mikkot@pacbell.net>
Reply-To: Mikko Tyolajarvi <mikkot@pacbell.net>
Cc: sec@42.org
X-send-pr-version: 3.113
X-GNATS-Notify:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021129134331.S321-100000>