Date: Wed, 27 Jan 2016 18:11:24 -0700 From: Warner Losh <imp@bsdimp.com> To: Steve Kiernan <stevek@juniper.net> Cc: Stanislav Galabov <sgalabov@gmail.com>, freebsd-arm@freebsd.org, freebsd-mips@freebsd.org Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c Message-ID: <55D21A1C-E1E3-4800-8069-8EA98A8F85A0@bsdimp.com> In-Reply-To: <20160127192015.64d0ded0@stevek-ubuntu.jnpr.net> References: <B4B24B7D-B3EE-4F37-9E89-24FF17294C70@gmail.com> <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> <CANiSyhR01wY65%2B2Nu%2B3Hucs%2BbDWyKhH_ejujG9CE39SaQQ2Wqg@mail.gmail.com> <20160127192015.64d0ded0@stevek-ubuntu.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 27, 2016, at 5:20 PM, Steve Kiernan <stevek@juniper.net> wrote: >=20 > On Sat, 23 Jan 2016 07:18:04 +0200 > Stanislav Galabov <sgalabov@gmail.com> wrote: >=20 >> It looks like only part of the original patch I submitted made it = into head >> (only the mx25l part). >> We also need to change sys/conf/files as Steve pointed out, as well = as >> sys/geom/geom_flashmap.c: >> https://bz-attachments.freebsd.org/attachment.cgi?id=3D165546 >=20 > One other thing that needs to be considered. The nand driver has an = ioctl > for getting chip parameters (see chip_param_io structure in > sys/dev/nand/nand_dev.h) and geom_flashmap only allows for > NAND_IO_GET_CHIP_PARAM to be passed to the provider. However, the CFI = and > SPI devices do not implement this and they probably should not as-is. > Something more generic to flash devices that are handled by = geom_flashmap > is probably in order. The different chip parameters shouldn=E2=80=99t be done through an ioctl = with geom. It should be done with geom attributes. We should implement a sensible = set for all three and have geom_flashmap use those instead of the ioctl. Warner --Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWqWq8AAoJEGwc0Sh9sBEAgokQAI5M65KgnMS90eGeIFoWcGSM RdwmoA79ic2anh3mzxI+18CQgV+NLX7A2dFPOCb+mXJcioTdirDns78LbQdsH4sr li659Ui84+bwuR0Ov8Qxi2ugyd2Z4iaFXITQ2G9l+lB1715ZLOEryVnMZaBbLyLl BnS/DuFuVh83CaDaYqQS0tA28dypaUk3uXb5I4RimUMVws824K+pePR6QeXShlHP z0Xf48rq3r2nBS4/jicQ8MLk6uA6kI/xjdMhbaMv3KxMPW2xdQfkvGCRjcXg41zA +Xi0XgUF+tL1LPmH0Gu4mZ/vG6oVWq3WrRT2a3r8l+qEnMJ5ezIbOMaNciaNOgbe 3M3gxBPsrp/ha1csTp9YmoRx7nzzKnmLkV3oAVlGrrf0lVNgsz8UJ+2v38LhMSeb q3wvenaEICtHYqCDgVXrEQu3AH9+qzD+D6LvqhOMJjJDfmf17fUs63wX5Eub4g4O OLodRn5ySWmXSCvZFPulC5Hi65CuUqJvL20pLSoQum0s/RGjWIh9B4/Ww933gOI1 Ab4L1MasQ5DHkeC4wsR60M44BnBR0slooAQJnTn2MT/JkSWLgdFT5dLYHKiwSaq8 KTjoDDMAlznh+XQQBmc/l8AElkVNEXcX+g/fqcz2l6mzxY/1VdTrCBpmSsVRJK7y +UcEDqHid5YWeBVcRQwd =Gb2T -----END PGP SIGNATURE----- --Apple-Mail=_4967476C-6D18-4BF8-BB72-F56B9EAA26B5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55D21A1C-E1E3-4800-8069-8EA98A8F85A0>