Date: Wed, 23 Jan 2002 09:22:00 -0600 From: "Jacques A. Vidrine" <n@nectar.cc> To: Will Andrews <will@csociety.org> Cc: ports@freebsd.org, trish@bsdunix.org Subject: Re: ports/34183: Update port: security/srp, various patches and fixes for compilation Message-ID: <20020123152200.GB27541@madman.nectar.cc> In-Reply-To: <200201222320.g0MNK2k27620@freefall.freebsd.org> References: <200201222320.g0MNK2k27620@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 22, 2002 at 03:20:02PM -0800, Will Andrews wrote: > > sed 's/^X//' >srp/files/patch-configure << 'END-of-srp/files/patch-configure' > > sed 's/^X//' >srp/files/patch-base::pam_eps::Makefile.in << 'END-of-srp/files/patch-base::pam_eps::Makefile.in' > > sed 's/^X//' >srp/files/patch-base::pam_eps::pam_eps_passwd.c << 'END-of-srp/files/patch-base::pam_eps::pam_eps_passwd.c' > > sed 's/^X//' >srp/files/patch-telnet::telnetd::sys_term.c-bb << 'END-of-srp/files/patch-telnet::telnetd::sys_term.c-bb' > > These are trivial patches and could easily have been replaced > with perl regexes. They should be removed. No, they should not be removed. A regex is cryptic. The patches are clear in their function. > > sed 's/^X//' >srp/files/patch-base::libmisc::utmp.c << 'END-of-srp/files/patch-base::libmisc::utmp.c' > > sed 's/^X//' >srp/files/patch-base::lib::utent.c << 'END-of-srp/files/patch-base::lib::utent.c' > > sed 's/^X//' >srp/files/patch-telnet::telnetd::sys_term.c-aa << 'END-of-srp/files/patch-telnet::telnetd::sys_term.c-aa' > > These are fairly trivial patches but probably would have taken > more work to do in a perl regex. I don't care either way. I do. Cheers, -- Jacques A. Vidrine <n@nectar.cc> http://www.nectar.cc/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020123152200.GB27541>