Date: Sat, 1 Nov 2014 08:47:16 -0200 From: Luiz Otavio O Souza <loos.br@gmail.com> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: Luiz Otavio O Souza <loos@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r273917 - head/sys/dev/gpio Message-ID: <CAJ8CS7o1RfRTbVmDEtRECtfFpQnUOcM%2B7xYhDV%2Ba_Xs55j0mrA@mail.gmail.com> In-Reply-To: <B3986980-D53E-4015-9EF1-4B317ADC6955@FreeBSD.org> References: <201410311915.s9VJFEDZ003525@svn.freebsd.org> <B3986980-D53E-4015-9EF1-4B317ADC6955@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 1, 2014 at 7:56 AM, Bjoern A. Zeeb wrote: > > On 31 Oct 2014, at 19:15 , Luiz Otavio O Souza wrote: > >> Author: loos >> Date: Fri Oct 31 19:15:14 2014 >> New Revision: 273917 >> URL: https://svnweb.freebsd.org/changeset/base/273917 >> >> Log: >> Fix the gpiobus locking by using a more sane model where it isn't necessary >> hold the gpiobus lock between the gpio calls. >> >> gpiobus_acquire_lock() now accepts a third parameter which tells gpiobus >> what to do when the bus is already busy. >> >> When GPIOBUS_WAIT wait is used, the calling thread will be put to sleep >> until the bus became free. >> >> With GPIOBUS_DONTWAIT the calling thread will receive EWOULDBLOCK right >> away and then it can act upon. >> >> This fixes the gpioiic(4) locking issues that arises when doing multiple >> concurrent access on the bus. > > I guess it was this commit that broke things: > > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c: In function 'gpioled_control': > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: 'GPIOBUS_DONTWAIT' undeclared (first use in this function) > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: (Each undeclared identifier is reported only once > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: for each function it appears in.) > --- gpioled.o --- > *** [gpioled.o] Error code 1 > > bmake: stopped in /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/AP121 > --- buildkernel --- > *** [buildkernel] Error code 1 Fixed in r273926. Sorry for the breakage. Luiz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ8CS7o1RfRTbVmDEtRECtfFpQnUOcM%2B7xYhDV%2Ba_Xs55j0mrA>