Date: Tue, 13 Dec 2016 14:20:31 -0800 From: Devin Teske <dteske@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Devin Teske <dteske@FreeBSD.org> Subject: Re: svn commit: r309918 - head/usr.sbin/bsdinstall/scripts Message-ID: <751FBC9A-2072-4CB0-8318-7F551BD8EB28@freebsd.org> In-Reply-To: <20161213212435.GA34587@stack.nl> References: <201612121848.uBCIm00M073404@repo.freebsd.org> <20161213212435.GA34587@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 13, 2016, at 1:24 PM, Jilles Tjoelker <jilles@stack.nl> wrote: >=20 > On Mon, Dec 12, 2016 at 06:48:00PM +0000, Devin Teske wrote: >> Author: dteske >> Date: Mon Dec 12 18:48:00 2016 >> New Revision: 309918 >> URL: https://svnweb.freebsd.org/changeset/base/309918 = <https://svnweb.freebsd.org/changeset/base/309918>; >=20 >> Log: >> Remove unnecessary `-n' parameter to head/tail >=20 > These -n options are not completely unnecessary since POSIX removed = the > obsolete forms without -n years ago, and some minimalistic > implementations (Busybox) followed suit. Therefore, although I use the > obsolete forms frequently interactively, I think head/tail -n should = be > the preferred form in scripts. >=20 > The obsolete form tail +N (where N is a number) should definitely be > avoided since it conflicts with a file named like that; head -N and = tail > -N are valid extensions to the standard. >=20 Thanks for keeping me abreast of the POSIX changes. I'll make the applicable change right now and should I see any other = instances, tackle those in the future as well. --=20 Cheers, Devin >> Modified: >> head/usr.sbin/bsdinstall/scripts/wlanconfig >>=20 >> Modified: head/usr.sbin/bsdinstall/scripts/wlanconfig >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/usr.sbin/bsdinstall/scripts/wlanconfig Mon Dec 12 = 18:45:52 2016 (r309917) >> +++ head/usr.sbin/bsdinstall/scripts/wlanconfig Mon Dec 12 = 18:48:00 2016 (r309918) >> @@ -175,8 +175,8 @@ fi >> # >> if [ "$BSDINSTALL_CONFIGCURRENT" ]; then >> # Get current country/regdomain for selected interface >> - WLAN_IFACE=3D$( wpa_cli ifname | tail -n 1 ) >> - INPUT=3D$( ifconfig $WLAN_IFACE list regdomain | head -n 1 ) >> + WLAN_IFACE=3D$( wpa_cli ifname | tail -1 ) >> + INPUT=3D$( ifconfig $WLAN_IFACE list regdomain | head -1 ) >> DEF_REGDOMAIN=3D$( echo $INPUT | cut -w -f 2 ) >> DEF_COUNTRY=3D$( echo $INPUT | cut -w -f 4 ) >> [ "$DEF_REGDOMAIN" =3D 0 ] && DEF_REGDOMAIN=3D"<not selected>" >=20 > --=20 > Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?751FBC9A-2072-4CB0-8318-7F551BD8EB28>