Date: Wed, 22 Nov 2017 22:17:20 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Mateusz Guzik <mjg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326107 - in head/sys: kern sys Message-ID: <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd> In-Reply-To: <201711222204.vAMM44FW023951@repo.freebsd.org> References: <201711222204.vAMM44FW023951@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7nc7fposwnz2k7e7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 22, 2017 at 10:04:04PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Wed Nov 22 22:04:04 2017 > New Revision: 326107 > URL: https://svnweb.freebsd.org/changeset/base/326107 >=20 > Log: > locks: pass the found lock value to unlock slow path > =20 > This avoids an explicit read later. > =20 > While here whack the cheaply obtainable 'tid' argument. >=20 > Modified: > head/sys/kern/kern_mutex.c > head/sys/kern/kern_rwlock.c > head/sys/kern/kern_sx.c > head/sys/sys/mutex.h > head/sys/sys/rwlock.h > head/sys/sys/sx.h This breaks ZFS: https://gist.github.com/lattera/93faa9c47ccc985ebda039ab31641c2c Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --7nc7fposwnz2k7e7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAloWPb8ACgkQaoRlj1JF bu6J6xAAhjqzFF2CmV8RRbER7RU4kVeD0YwC71Loet/c7wwA2bX6eJWgBz3fT15Q qHdCWqo5lLwBg12ifF0eU05INH/9NpN9SPYPJ6e7ZUD4Z1anzMFggdmqak6Ku0nM TKS4bPwJGKSk9ndOhmf/NqnyfAikrA+mVsgGAVelzn6xBWC7gdNXWAS3p70/ddtP fpG1dFzXdWC3dfp4fghs2t8kzqFRQ0c5MZy1FobMv3Q8Qr4GA0yPBd8whHyaQvo/ euwo053hMZmPmKwXi6hAP215gv9573BByFWpa2+LLyhJhB16OwvFDpbffut0Ylws JCrkxxOGPVGhxVvxe9oXRYFHbPZgP3/T0IehTE+oEfHctJDBedhP2CWb+VD4cRrN GCEVFzGofyZaDl51sf2jwSqWesNcIukicfhuHjyB1VPEx50mCxYq1KgGAg1aaSRO zORmmK/AC1Q0sWA21WrAEikt5hVQCQQb1t5qr/QiOoCSuX5Om7UPmLfSefoiirbU RAZ4AbRrszCA8eEGGF+UVxHHO59dyBFemTMM4SBhJDTLBMMfG4XFkERVeW916Hld PQCJvQflhSMAJZwZUGMyZNu3O7z4GSh3XU8OCMd+mQ3lZJ+uPlG6/5XZVOGsqNaf Wd2gWUiqOXXrr5uCJBKqPaEB04KFKh85fqVOkGX4Fps4WlSS6y8= =+HQZ -----END PGP SIGNATURE----- --7nc7fposwnz2k7e7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171123031720.4iyoyvfyhxsltexw>