Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jun 2014 22:46:32 -0400
From:      Alexander Kabaev <kabaev@gmail.com>
To:        Andrey Chernov <ache@freebsd.org>
Cc:        current@FreeBSD.org
Subject:   Re: Latest -current panic in uaudio_detach() / bus_dmamem_free()
Message-ID:  <20140622224632.31b4ce3b@kan>
In-Reply-To: <53A78B24.6050805@freebsd.org>
References:  <53A78B24.6050805@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/M.c8Z2_nCFkcdaOcqEFRahL
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 23 Jun 2014 06:04:20 +0400
Andrey Chernov <ache@freebsd.org> wrote:

> Always happens at shutdown after all buffers are synced, see
> screenshot: http://i.imgur.com/8WXTMPj.png
>=20
> --=20
> http://ache.vniz.net/

Hi Andrey,

there's not to much to go on from the screenshoot alone and one would
expect more details on the crash from people with your experience :)

Please provide us with the information on the actual audio hardware
you are using, preferably in form of a dmesg output. This revision is
your culpit:
 http://svnweb.freebsd.org/changeset/base/267581 and I have strong
 suspicion that restoring the NULL check on dmatag in the chunk below
 will cure your crash.

-- Modified: head/sys/dev/sound/pcm/buffer.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
--- head/sys/dev/sound/pcm/buffer.c	Tue Jun 17 14:47:49
2014	(r267580) +++ head/sys/dev/sound/pcm/buffer.c	Tue
Jun 17 16:07:57 2014	(r267581) @@ -139,10 +139,9 @@
sndbuf_free(struct snd_dbuf *b)=20
 	if (b->buf) {
 		if (b->flags & SNDBUF_F_MANAGED) {
-			if (b->dmamap)
+			if (b->buf_addr)
 				bus_dmamap_unload(b->dmatag,
b->dmamap);
-			if (b->dmatag)
-				bus_dmamem_free(b->dmatag, b->buf,
b->dmamap);
+			bus_dmamem_free(b->dmatag, b->buf, b->dmamap);
 		} else
 			free(b->buf, M_DEVBUF);
 	}

--
Alexander Kabaev

--Sig_/M.c8Z2_nCFkcdaOcqEFRahL
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iD8DBQFTp5UPQ6z1jMm+XZYRAobzAKCpvN5clFK3UbbzkvJpr98Sd7LnVgCffsNn
KeEeXlCLt6U76sPbsn3rGFI=
=tBeA
-----END PGP SIGNATURE-----

--Sig_/M.c8Z2_nCFkcdaOcqEFRahL--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140622224632.31b4ce3b>