Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Apr 2017 23:09:41 +0300
From:      Vladimir Kondratyev <vladimir@kondratyev.su>
To:        =?UTF-8?Q?Jan_Kokem=C3=BCller?= <jan.kokemueller@gmail.com>
Cc:        current@freebsd.org, freebsd-mobile@freebsd.org
Subject:   Re: CFT: EVDEV support in psm(4) driver
Message-ID:  <4a108371daf4c13dcc8be953ffccd2d5@kondratyev.su>
In-Reply-To: <5446ec03-c501-a369-01fc-e58a7d8712d9@gmail.com>
References:  <5fa9225de944d6cdac0b7e5749b452a9@kondratyev.su> <5446ec03-c501-a369-01fc-e58a7d8712d9@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-04-17 13:59, Jan Kokem=C3=BCller wrote:
> Hi Vladimir,
> this patch works great for me!
Great!

> I am not using xf86-input-mouse or xf86-input-keyboard.
You stepped on minefield. xf86-input-keyboard does things that should
be done by xorg-server like terminal blanking, disabling keybuffering
and so on. I had seen (and heard) some funny effects before copied
required ~20 lines of code from xf86-input-keyboard to xorg-server.

>  - TrackPoint scrolling holding the middle button
Thanks for report. I was not able to test trackpoint due to lack of=20
hardware.

> The only thing that doesn't work out of the box is the mouse pointer
> on the VT console. It wouldn't be hard though to write a small tool
> that uses libinput to translate Evdev events into CONS_MOUSECTL ioctls
> needed for the VT pointer.
Just run moused on /dev/psm0. Unlike usermode drivers like=20
xf86-input-synaptics
in psm mode, in-kernel driver keeps psm0 device unbusied in sysmouse=20
mode.

> Some comments:
>  - PS2_MOUSE_SYNAPTICS_PRODUCT should be 0x0007, not 0x0009
> (http://lxr.free-electrons.com/source/drivers/input/mouse/psmouse.h#L86=
)
>  - The TrackPoint should be added with product id 0x000A as on Linux
> and with the INPUT_PROP_POINTING_STICK Evdev property set
>  - I think it would be better if the same Evdev device names were
> exposed as on Linux (for example "SynPS/2 Synaptics TouchPad"). Many
> scripts using xinput to change device properties depend on the Linux
> device names.
>=20
> I've added a patch and comments to https://reviews.freebsd.org/D10265 .
Patch looks good to me. I will merge it after small refactoring.

Thank you!

--=20
WBR
Vladimir Kondratyev



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4a108371daf4c13dcc8be953ffccd2d5>