Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jul 2003 16:21:40 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Philipp Mergenthaler <philipp.mergenthaler@stud.uni-karlsruhe.de>
Cc:        freebsd-i386@freebsd.org
Subject:   Re: i386/54963: Left over/outdated comment in NOTES
Message-ID:  <20030728161221.U2380@gamplex.bde.org>
In-Reply-To: <200307272230.h6RMUgO7002562@i609a.hadiko.de>
References:  <200307272230.h6RMUgO7002562@i609a.hadiko.de>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Jul 2003, Philipp Mergenthaler wrote:

> >Description:
> When the math emulators were removed in version 1.1091, one comment line
> remained.
>
> Index: NOTES
> ===================================================================
> RCS file: /ncvs/src/sys/i386/conf/NOTES,v
> retrieving revision 1.1091
> diff -u -r1.1091 NOTES
> --- NOTES	22 Jul 2003 08:11:15 -0000	1.1091
> +++ NOTES	27 Jul 2003 22:10:20 -0000
> @@ -188,7 +188,6 @@
>
>  # Debug options
>  options 	NPX_DEBUG	# enable npx debugging (FPU/math emu)
> -					#new math emulator
>

Also, the parenthetical comment remained.  I use this patch:

%%%
Index: NOTES
===================================================================
RCS file: /home/ncvs/src/sys/i386/conf/NOTES,v
retrieving revision 1.1091
diff -u -0 -r1.1091 NOTES
--- NOTES	22 Jul 2003 08:11:15 -0000	1.1091
+++ NOTES	25 Jul 2003 20:49:01 -0000
@@ -190,2 +195 @@
-options 	NPX_DEBUG	# enable npx debugging (FPU/math emu)
-					#new math emulator
+options 	NPX_DEBUG	# enable npx debugging
%%%

This is not exactly an improvement, since the comment now just echoes
the code.  Perhaps no comment is correct.  Anyone debugging NPX doesn't
need to be reminded that it is i486speak for FPU.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030728161221.U2380>