Date: Mon, 04 Dec 2000 14:09:02 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Akinori MUSHA <knu@iDaemons.org> Cc: Michael Haro <mharo@FreeBSD.org>, FreeBSD-ports <freebsd-ports@FreeBSD.org> Subject: Re: portlint update Message-ID: <3A2B895D.D67E403A@FreeBSD.org> References: <86u28kwghs.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------D2C59009B7567C685F0A4E92 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Akinori MUSHA wrote: > Hi, > > Please review and give me suggestion and approval to commit the > attached patch on portlint. > > It makes portlint conform to the new layout, and adds a check for > INSTALLS_SHLIB. Currently pkg-* doesn't seem to be checked at all. :( > > -- > / > /__ __ Akinori.org / MUSHA.org > / ) ) ) ) / FreeBSD.org / Ruby-lang.org > Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp > > "We're only at home when we're on the run, on the wing, on the fly" > > Index: Makefile > =================================================================== > RCS file: /home/ncvs/ports/devel/portlint/Makefile,v Some time ago (3 months) I submitted patch which detects different misbehaviour - direct usage of ldconfig in pkg-plist. If you can, please merge this patch with yours before comitting. Thanks! -Maxim --------------D2C59009B7567C685F0A4E92 Content-Type: text/plain; charset=koi8-r; name="portlint.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="portlint.diff" --- portlint 2000/06/29 08:18:53 1.1 +++ portlint 2000/06/29 08:15:52 @@ -250,6 +250,9 @@ TCLTK ftp://ftp.cs.tu-berlin.de/pub/tcl/distrib/ TCLTK ftp://ftp.srcc.msu.su/mirror/ftp.scriptics.com/pub/tcl/ TCLTK ftp://ftp.lip6.fr/pub/tcl/distrib/ +SOURCEFORGE ftp://download.sourceforge.net/pub/sourceforge/ +SOURCEFORGE http://download.sourceforge.net/ +SOURCEFORGE ftp://ftp.kddlabs.co.jp/sourceforge/ EOF my ($j, $k) = split(/\t+/, $i); $predefined{$k} = $j; @@ -416,12 +419,17 @@ $inforemoveseen = $.; push(@unexec_info, $1); } elsif ($_ =~ /^\@(exec|unexec)/) { - if ($ldconfigwithtrue - && /ldconfig/ - && !/\/usr\/bin\/true/) { - &perror("FATAL: $file $.: ldconfig ". - "must be used with ". - "\"||/usr/bin/true\"."); + if (/ldconfig/) { + if ($ldconfigwithtrue + && !/\/usr\/bin\/true/) { + &perror("FATAL: $file $.: ldconfig ". + "must be used with ". + "\"||/usr/bin/true\"."); + } + &perror("WARN: $file $.: possible ". + "direct use of ldconfig ". + "in PLIST found. use ". + "INSTALLS_SHLIB instead."); } } elsif ($_ =~ /^\@(comment)/) { $rcsidseen++ if (/\$$rcsidstr[:\$]/); --------------D2C59009B7567C685F0A4E92-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A2B895D.D67E403A>