Date: Tue, 25 Jun 2019 15:37:05 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Piotr Kubaj <pkubaj@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard Message-ID: <20190625133704.v3mchm3ofxxol7zl@ivaldir.net> In-Reply-To: <201906241810.x5OIAu1h080487@repo.freebsd.org> References: <201906241810.x5OIAu1h080487@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dybbz7d7sjgdprmn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 24, 2019 at 06:10:56PM +0000, Piotr Kubaj wrote: > Author: pkubaj > Date: Mon Jun 24 18:10:55 2019 > New Revision: 505045 > URL: https://svnweb.freebsd.org/changeset/ports/505045 >=20 > Log: > sysutils/plasma5-ksysguard: fix build with GCC-based architectures > =20 > Link with libinotify explicitly to fix linking on GCC architectures. > =20 > PR: 238702 > Approved by: tcberner (maintainer, mentor) >=20 > Modified: > head/sysutils/plasma5-ksysguard/Makefile >=20 > Modified: head/sysutils/plasma5-ksysguard/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:07:12 2019 (r5= 05044) > +++ head/sysutils/plasma5-ksysguard/Makefile Mon Jun 24 18:10:55 2019 (r5= 05045) > @@ -23,5 +23,6 @@ OPTIONS_SUB=3D yes > =20 > INOTIFY_DESC=3D Filesystem alteration notifications using inotify > INOTIFY_LIB_DEPENDS=3D libinotify.so:devel/libinotify > +INOTIFY_LDFLAGS=3D -linotify > =20 > .include <bsd.port.mk> >=20 At least do provide a -L path to search for the libinotify, note that if th= is works on gcc it is only because localbase is automatically added to the sea= rch of when using gcc from ports. (or a USES=3Dlocalbase) =20 if this option is working correctly with clang based architecture it is pro= bably that the build system already append -linotify at the right place, meaning = the analysis that led to this fix is wrong and now binary produced by the port = is linked to libinotify while maybe a some of them only needs that. Best regards, Bapt --dybbz7d7sjgdprmn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0SI30ACgkQY4mL3PG3 PlpfJBAAnvFzYb6f+G22k5KKvPSHEMUQYLFZkspZnft7NhJL/s9FBDdWRe0Bv6p7 /K5WblVywvPbun6mvJ3P4vNy8EoF+T8HoEMzNQP6qPtONrCZWruHJGqyquaOjQoK RlcS8BIUaSlVP5zFfa2OP6/lQC6C9v/r2E/VS9ZjHxOE+kEHvrfRVqBjyoimZw10 r3SuQnd5/hYXOTGCcJH1bl+axjis8XJkaZCIuOMOSjmukNAfIUMZoXepa/p3Q+kY hxtZRjQiVaZh54hDIplnVL8IfWMyOZTk+ZgVo5DOXzxqeGUVkD0n6MJ/lRXwvmTa EdTzDResBIalC8/2UEyA1BzS59pqYKp+5QKHKWIFl/+pyx+eH6N8DOBQdEFYUFyV 1DRXPUFg6v92E3BI9ly3nJZ1IuCBiQsDs6gTYuHHag8YFx5d1QfRzjJ8e4qn31/1 TSUUkzd9ybHzaLs4PuqviPJueT/V0DqqSKCb5yPjgOza+5LPFdDPjIEwFfRWhtCx v2/+kSIqvLGhK93MYvK/e5F7WenLr7fJPCjbPTYfvB/u9eBXyBSuyxaY9Tz2+Ws2 Uhle1HEjryAnOPpiHQBKj0J0YX6dFkmB5sXJAYqBMK+jR/xyX2Ijeu502xmXdtc5 4mwLIsB9Bcdif1cwCaQUaCVLx3jK/lj51XPekm0OO3P+97c5bIs= =lUDQ -----END PGP SIGNATURE----- --dybbz7d7sjgdprmn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190625133704.v3mchm3ofxxol7zl>